Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain: revert workarounds and fix regressions in bumping #6103

Closed
6 of 7 tasks
BugenZhao opened this issue Oct 28, 2022 · 3 comments
Closed
6 of 7 tasks

toolchain: revert workarounds and fix regressions in bumping #6103

BugenZhao opened this issue Oct 28, 2022 · 3 comments
Assignees
Labels
type/bug Something isn't working type/build

Comments

@BugenZhao
Copy link
Member

BugenZhao commented Oct 28, 2022

Too many workarounds are introduced when bumping toolchain to 2022-10-16 in #6025, including unnecessary dyn, unsafe and unnecessary allocation. We should revert them as soon as possible.

@github-actions github-actions bot added this to the release-0.1.14 milestone Oct 28, 2022
@BugenZhao BugenZhao added type/bug Something isn't working type/build labels Oct 28, 2022
@skyzh
Copy link
Contributor

skyzh commented Oct 28, 2022

It's 2022-10-16 indeed. Wrong title for the previous PR.

@BugenZhao BugenZhao changed the title toolchain: revert workarounds in bumping toolchain: revert workarounds and fix regressions in bumping Nov 1, 2022
@fuyufjh
Copy link
Member

fuyufjh commented Nov 10, 2022

@BugenZhao Just assigned you as the tracker. Please help to distribute the work. Thank U❤️

@BugenZhao
Copy link
Member Author

Let's close this and leave #6131 alone. It seems not a compiler frontend stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working type/build
Projects
None yet
Development

No branches or pull requests

3 participants