Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQL commands to show sources and connectors #7344

Closed
xx01cyx opened this issue Jan 12, 2023 · 5 comments
Closed

feat: SQL commands to show sources and connectors #7344

xx01cyx opened this issue Jan 12, 2023 · 5 comments
Assignees
Labels
help wanted Issues that need help from contributors type/feature

Comments

@xx01cyx
Copy link
Contributor

xx01cyx commented Jan 12, 2023

After #7110 and #7281, we should support showing all connectors (and maybe showing all sources as well).

Two solutions for this:

    • Support SHOW SOURCES to show all sources created by CREATE SOURCE. Do not include those created by CREATE TABLE WITH (connector = 'xxx').
    • Support SHOW CONNECTORS to show all connectors created by both CREATE SOURCE and CREATE TABLE WITH (connector = 'xxx').
  1. Only support SHOW SOURCES to show all connectors created by both CREATE SOURCE and CREATE TABLE WITH (connector = 'xxx').

@xx01cyx
Copy link
Contributor Author

xx01cyx commented Jan 12, 2023

cc. @st1page @yezizp2012 @fuyufjh

@github-actions github-actions bot added this to the release-0.1.16 milestone Jan 12, 2023
@tabVersion
Copy link
Contributor

upvote for solution 1.

connector should be seen as a component inside a source or table. If a connector is created within a table, it can not be seen as a source.

@fuyufjh
Copy link
Member

fuyufjh commented Jan 30, 2023

I concur with @tabVersion

@hzxa21
Copy link
Collaborator

hzxa21 commented Feb 9, 2023

Since MATERIALIZED SOURCE has been changed to source TABLE, I think we should also show it in show tables and information_schema.tables (See #7739 )

@xx01cyx xx01cyx removed this from the release-0.18 milestone Mar 20, 2023
@neverchanje
Copy link
Contributor

So far we've supported a bunch of ways for displaying the tables and sources:

  • show sources
  • show tables
  • rw_tables
  • rw_sources

There is no need to add more. Let's close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need help from contributors type/feature
Projects
None yet
Development

No branches or pull requests

5 participants