Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement trill@enclose #3658

Open
craigsapp opened this issue Apr 27, 2024 · 2 comments
Open

Implement trill@enclose #3658

craigsapp opened this issue Apr 27, 2024 · 2 comments
Labels
enhancement low priority

Comments

@craigsapp
Copy link
Contributor

It would be useful to implement trill@enclose:

Screenshot 2024-04-27 at 2 37 51 PM
Click to view MEI data for above example. 
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/5.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/5.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="5.0">
 <meiHead>
  <fileDesc>
   <titleStmt>
    <title />
   </titleStmt>
   <pubStmt>
   </pubStmt>
  </fileDesc>
  <encodingDesc>
   <appInfo>
    <application isodate="2024-04-27T14:36:06" version="4.2.0-dev-764d3d2-dirty">
     <name>Verovio</name>
     <p>Transcoded from Humdrum</p>
    </application>
   </appInfo>
  </encodingDesc>
 </meiHead>
 <music>
  <body>
   <mdiv xml:id="mr4fm5c">
    <score xml:id="sq893ww">
     <scoreDef xml:id="sgdjqkn" midi.bpm="400.000000" tempo.dist="3.0000vu">
      <staffGrp xml:id="sqs4skq">
       <staffDef xml:id="staffdef-L1F1" n="1" lines="5">
        <clef xml:id="cf3sqq2" shape="G" line="2" />
       </staffDef>
      </staffGrp>
     </scoreDef>
     <section xml:id="section-L1F1">
      <measure xml:id="measure-L1" n="1">
       <staff xml:id="staff-L1F1" n="1">
        <layer xml:id="layer-L1F1N1" n="1">
         <note xml:id="note-L4F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <trill xml:id="trill-L4F1" staff="1" startid="#note-L4F1" enclose="brack" />
       <dir xml:id="dir-L3F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="r1e9mrqz" fontstyle="normal">brack</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L5" n="2">
       <staff xml:id="staff-L5F1N1" n="1">
        <layer xml:id="layer-L5F1N1" n="1">
         <note xml:id="note-L7F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <trill xml:id="trill-L7F1" staff="1" startid="#note-L7F1" enclose="paren" />
       <dir xml:id="dir-L6F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="rnpla08" fontstyle="normal">paren</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L8" n="3">
       <staff xml:id="staff-L8F1N1" n="1">
        <layer xml:id="layer-L8F1N1" n="1">
         <note xml:id="note-L10F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <trill xml:id="trill-L10F1" staff="1" startid="#note-L10F1" enclose="box" />
       <dir xml:id="dir-L9F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="r1czzpvv" fontstyle="normal">box</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L11" right="end" n="4">
       <staff xml:id="staff-L11F1N1" n="1">
        <layer xml:id="layer-L11F1N1" n="1">
         <note xml:id="note-L13F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <trill xml:id="trill-L13F1" staff="1" startid="#note-L13F1" enclose="none" />
       <dir xml:id="dir-L12F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="r16fpfzi" fontstyle="normal">none</rend>
       </dir>
      </measure>
     </section>
    </score>
   </mdiv>
  </body>
 </music>
</mei>
@craigsapp
Copy link
Contributor Author

Also for mordents and turns at the same time if convenient.

Screenshot 2024-04-27 at 2 45 25 PM
Click to view MEI data for above example. 
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/5.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/5.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="5.0">
 <meiHead>
  <fileDesc>
   <titleStmt>
    <title />
   </titleStmt>
   <pubStmt>
   </pubStmt>
  </fileDesc>
  <encodingDesc>
   <appInfo>
    <application isodate="2024-04-27T14:42:53" version="4.2.0-dev-764d3d2-dirty">
     <name>Verovio</name>
     <p>Transcoded from Humdrum</p>
    </application>
   </appInfo>
  </encodingDesc>
 </meiHead>
 <music>
  <body>
   <mdiv xml:id="mmmarc1">
    <score xml:id="ssnp0af">
     <scoreDef xml:id="s12b63ni" midi.bpm="400.000000" tempo.dist="3.0000vu">
      <staffGrp xml:id="s81f105">
       <staffDef xml:id="staffdef-L1F1" n="1" lines="5">
        <clef xml:id="c15u9drc" shape="G" line="2" />
       </staffDef>
      </staffGrp>
     </scoreDef>
     <section xml:id="section-L1F1">
      <measure xml:id="measure-L1" n="1">
       <staff xml:id="staff-L1F1" n="1">
        <layer xml:id="layer-L1F1N1" n="1">
         <note xml:id="note-L4F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <mordent xml:id="mordent-L4F1" staff="1" enclose="brack" startid="#note-L4F1" place="above" form="upper" />
       <dir xml:id="dir-L3F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="rr1hmpo" fontstyle="normal">brack</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L5" n="2">
       <staff xml:id="staff-L5F1N1" n="1">
        <layer xml:id="layer-L5F1N1" n="1">
         <note xml:id="note-L7F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <mordent xml:id="mordent-L7F1" staff="1" enclose="paren" startid="#note-L7F1" place="above" form="upper" long="true" />
       <dir xml:id="dir-L6F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="r1n77z8a" fontstyle="normal">paren</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L8" right="dbl" n="3">
       <staff xml:id="staff-L8F1N1" n="1">
        <layer xml:id="layer-L8F1N1" n="1">
         <note xml:id="note-L10F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <mordent xml:id="mordent-L10F1" staff="1" enclose="box" startid="#note-L10F1" place="above" form="lower" />
       <dir xml:id="dir-L9F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="r1dwwdt2" fontstyle="normal">box</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L11" n="4">
       <staff xml:id="staff-L11F1N1" n="1">
        <layer xml:id="layer-L11F1N1" n="1">
         <note xml:id="note-L13F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <turn xml:id="t1onlih5" staff="1" enclose="brack" startid="#note-L13F1" form="upper" />
       <dir xml:id="dir-L12F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="raudwpd" fontstyle="normal">brack</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L14" n="5">
       <staff xml:id="staff-L14F1N1" n="1">
        <layer xml:id="layer-L14F1N1" n="1">
         <note xml:id="note-L16F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <turn xml:id="t1nahkcu" staff="1" enclose="paren" startid="#note-L16F1" delayed="true" form="upper" />
       <dir xml:id="dir-L15F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="rewow4u" fontstyle="normal">paren</rend>
       </dir>
      </measure>
      <measure xml:id="measure-L17" right="end" n="6">
       <staff xml:id="staff-L17F1N1" n="1">
        <layer xml:id="layer-L17F1N1" n="1">
         <note xml:id="note-L19F1" dur="1" oct="4" pname="f" accid.ges="n" />
        </layer>
       </staff>
       <turn xml:id="t1uggfh8" staff="1" enclose="box" startid="#note-L19F1" delayed="true" form="lower" />
       <dir xml:id="dir-L18F1" place="below" staff="1" tstamp="1.000000">
        <rend xml:id="rplk8yd" fontstyle="normal">box</rend>
       </dir>
      </measure>
     </section>
    </score>
   </mdiv>
  </body>
 </music>
</mei>

@lpugin
Copy link
Contributor

lpugin commented Feb 17, 2025 •
edited
Loading

One issue here is that SMuFL baseline is not the same for the trill symbols than for the bracket symbols (here using accidental ones).

Image

Should having trill-specific enclosing brackets or parenthesis be submitted as an addition to SMuFL first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpugin @craigsapp