Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark with scipy or numpy implementation? #3

Open
Xiaojieqiu opened this issue Nov 19, 2019 · 3 comments
Open

benchmark with scipy or numpy implementation? #3

Xiaojieqiu opened this issue Nov 19, 2019 · 3 comments

Comments

@Xiaojieqiu
Copy link

Hey @ritchieng thanks for implementing this method so quickly! I am curious about the performance of this method comparing to other standard methods, implemented in scipy or numpy. Is it possible for us to see some benchmarking regarding this implementation?

@ritchieng
Copy link
Owner

Hi @Xiaojieqiu, this should be easy. I'll provide a comparison of NumPy vs PyTorch by this week.

For large matrices, I would say a highly optimized PyTorch version (JIT and CUDA) would be very fast because you can run many function calls in parallel on the GPU and once you compile the function, you don't need the Python interpreter on subsequent calls. This will be implemented #2

@Xiaojieqiu
Copy link
Author

that will be wonderful, I am looking forward to seeing those benchmarks

@hypnopump
Copy link

any progress??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants