Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bahaviour on long press #48

Open
mokurin000 opened this issue Apr 1, 2023 · 2 comments
Open

fix bahaviour on long press #48

mokurin000 opened this issue Apr 1, 2023 · 2 comments
Labels

Comments

@mokurin000
Copy link

imo, it's strange that piano-rs will detect long press as rapid clicks

@ritiek
Copy link
Owner

ritiek commented Apr 1, 2023

I don't think crossterm (and more so the version used in piano-rs) allows to detect key releases. I'm not sure if it's even possible to detect key up presses in terminals. Might want to use a GUI to properly implement things like this.

@ritiek ritiek added the wontfix label Apr 1, 2023
@mokurin000
Copy link
Author

mokurin000 commented Apr 1, 2023

I don't think crossterm (and more so the version used in piano-rs) allows to detect key releases. I'm not sure if it's even possible to detect key up presses in terminals. Might want to use a GUI to properly implement things like this.

yeah... may need switch to a gui backend (and render as what a terminal emulator do), thus need few of work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants