-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase array size #57
Comments
The problematic code from requests.c was moved to defines.h but the issue still stands. I would like to fix this. Thanks! |
Actually, the code is ok it's just the name of defined limits that are wrong: Virtual-Assistant/utils/defines.h Lines 9 to 10 in 3905ebd
in Virtual-Assistant/utils/defines.h Line 44 in 3905ebd
It should be const char *classifier[LAST_FIELD][NUM_CLASS][NUM_WORDS]
This is not a functional bug but it could be misleading. Let me know if you would still want this fixed. |
@simonastefan Lets give it a try, I was curious about hardcoded limits while merging that PR also. Please check if your suggestion works well. |
In requests.c the class arrays are initialized with maximum word length 10, but for restaurant_class the word length is 11 for "restaurants" and 12 if '\0' is included (code below)
char *restaurant_class[10][10] = { {"Please", "find", "some", "restaurants"}, {"Find", " ", "some", "restaurants"}, {"Show", " ", " ", "restaurants"}, {"Find", "places", "to", "eat"} };
The text was updated successfully, but these errors were encountered: