fix(embed all): Changed selector from attribute name to class name

ritz078 · Nov 7, 2015 · 5d72dc8 · 5d72dc8
1 parent e4a3fc2
commit 5d72dc8
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 21 deletions.
diff --git a/demo/index.html b/demo/index.html
@@ -32,7 +32,7 @@
 
 <h1>Loading embed.js in a block</h1>
 
-<div id="block">
+<div id="block" class="block">
 **Pulchritudines** nocere, :heart: tanquam ~~talis~~ hibrida.A falsis, brodium :+1: salvus gabalium.Nunquam
 promissio @(iit roorkee) http://iitr.ac.in caesium.Cum rumor https://twitter.com/IGN/status/652941146054881281
 peregrinationes https://www.flickr.com/photos/xdjio/226228060/, omnes ususes http://www.sample-videos.com/video/mp4/240/big_buck_bunny_240p_50mb.mp4 https://soundcloud.com/the-bugle/bugle-179-playas-gon-play
@@ -48,7 +48,7 @@ <h1>Loading embed.js in a block</h1>
 ```
 Flavum, ferox http://open.spotify.com/track/4th1RQAelzqgY7wL53UGQt torquiss vix aperto de http://plnkr.co/edit/AK732k bi-color, http://www.iitr.ac.in/Main/assets/images/topold.jpg audax nixus.Pol, alter devatio!Crescere aliquando ducunt ad noster lixa. :smile: :P https://www.youtube.com/watch?v=bQRLVxZHKPs http://www.liveleak.com/view?i=42a_1426999994 https://gist.github.com/jeremiahlee/1748966 https://gist.github.com/thomasmb/7132686 https://twitter.com/ProductHunt/status/652826210666418176/photo/1 http://www.ted.com/talks/monica_lewinsky_the_price_of_shame http://www.dailymotion.com/video/x2k8un2_2015-wc-nz-vs-wi-holder-reacts-on-guptills-237_sport https://vine.co/v/bjHh0zHdgZT https://vimeo.com/119199079 http://www.w3schools.com/html/horse.mp3
 </div>
-<div id="block2">
+<div id="block2" class="block">
 Cur rumor nocere?Emeritis adelphis satis perderes domina est.Gloss cadunt in bi-color brema!
 @(IIT Roorkee) Bi-color habitio virtualiter imitaris amicitia est.Teres tatas ducunt ad racana.Genetrixs
 prarere in
@@ -85,7 +85,7 @@ <h1>Loading embed.js in a block</h1>
 	})
 
 
-	// ejs.applyEmbedJS();
+	// ejs.applyEmbedJS("block");
 </script>
 
 </body>

diff --git a/dist/embed.min.js b/dist/embed.min.js
diff --git a/src/embed.js b/src/embed.js
diff --git a/src/embed.js.map b/src/embed.js.map
diff --git a/src/js/embed.es6 b/src/js/embed.es6
@@ -200,11 +200,12 @@ const helper = require('./modules/video/helper.es6');
 
     let ejs = {
         instances: [],
-        elements: utils.getElementsByAttributeName('data-embed-js'),
+        elements: [],
         setOptions: function(options) {
             globalOptions = utils.deepExtend(defaultOptions, options)
         },
-        applyEmbedJS: function() {
+        applyEmbedJS: function(className) {
+            this.elements = document.getElementsByClassName(className)
             for (let i = 0; i < this.elements.length; i++) {
                 let option = {
                     element: this.elements[i]

diff --git a/src/js/modules/utils.es6 b/src/js/modules/utils.es6
@@ -132,18 +132,6 @@ var utils = {
         }
     },
 
-    getElementsByAttributeName: (attribute) => {
-        let matchingElements = [];
-        let allElements = document.getElementsByTagName('*');
-        for (let i = 0, n = allElements.length; i < n; i++) {
-            if (allElements[i].getAttribute(attribute) !== null) {
-                // Element exists with attribute. Add to array.
-                matchingElements.push(allElements[i]);
-            }
-        }
-        return matchingElements;
-    },
-
     /**
      * Returns a cloned object
      * @param  {object} obj