feat(pegboard): add container runner and manager #1144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
MasterPtato
force-pushed
the
09-11-feat_pegboard_add_container_runner_and_manager
branch
from
dcdba4c to
b6008e8
Compare
This was referenced Sep 12, 2024
MasterPtato
force-pushed
the
09-10-feat_pegboard_add_client_wf
branch
from
f5ba448 to
d86899e
Compare
MasterPtato
force-pushed
the
09-11-feat_pegboard_add_container_runner_and_manager
branch
from
b6008e8 to
1bcc0f3
Compare
This was referenced Sep 16, 2024
This was referenced Sep 24, 2024
MasterPtato
force-pushed
the
09-10-feat_pegboard_add_client_wf
branch
from
d86899e to
458de12
Compare
MasterPtato
force-pushed
the
09-11-feat_pegboard_add_container_runner_and_manager
branch
from
1bcc0f3 to
91cd21c
Compare
MasterPtato
force-pushed
the
09-10-feat_pegboard_add_client_wf
branch
from
458de12 to
784fa01
Compare
MasterPtato
force-pushed
the
09-11-feat_pegboard_add_container_runner_and_manager
branch
from
91cd21c to
070d36b
Compare
MasterPtato
force-pushed
the
09-10-feat_pegboard_add_client_wf
branch
from
784fa01 to
4bc4443
Compare
MasterPtato
force-pushed
the
09-11-feat_pegboard_add_container_runner_and_manager
branch
from
070d36b to
ba4b363
Compare
This was referenced Oct 1, 2024
Closed
NathanFlurry
reviewed
Oct 4, 2024
| } | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize)] | ||
| pub enum Stakeholder { |
NathanFlurry
previously requested changes
Oct 4, 2024
| /// identify the reasons for program crashes from the container's output. | ||
| const MAX_PREVIEW_LINES: usize = 128; | ||
|
|
||
| fn main() -> anyhow::Result<()> { |
There was a problem hiding this comment.
we should have a main_inner that catches errors and writes it to a file in order to catch container-runner errors
| match command { | ||
| protocol::Command::StartContainer { | ||
| container_id, | ||
| image_artifact_url, |
There was a problem hiding this comment.
wondering if we should pass the ats ips and let the container runner decide the ip. this makes RVTEE-625 super simple
There was a problem hiding this comment.
That will likely be the case down the line. Do you want me to implement it for MVP?
| let container_path = ctx.container_path(self.container_id); | ||
|
|
||
| let mut env = vec
Merge activity
|
NathanFlurry
pushed a commit
that referenced
this pull request
Oct 9, 2024
<!-- Please make sure there is an issue that this PR is correlated to. --> Fixes RVTEE-605 Fixes RVTEE-607 ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
09-11-feat_pegboard_add_container_runner_and_manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RVTEE-605
Fixes RVTEE-607
Changes