Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolchain): fix js-utils build paths on windows #1720

Conversation

NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Dec 29, 2024

Fixes RVT-4491
Fixes RVT-4505

Copy link

cloudflare-workers-and-pages bot commented Dec 29, 2024

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8adb679
Status: ✅  Deploy successful!
Preview URL: https://3ef53411.rivet.pages.dev
Branch Preview URL: https://12-27-fix-toolchain-fix-js-u.rivet.pages.dev

View logs

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

graphite-app bot commented Dec 29, 2024

Merge activity

  • Dec 29, 2:00 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 29, 2:00 AM EST: CI is running for this PR on a draft PR: #1721
  • Dec 29, 2:02 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI (cargo-check-main)).
  • Dec 29, 2:10 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 29, 2:10 AM EST: CI is running for this PR on a draft PR: #1723
  • Dec 29, 2:15 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1723.

NathanFlurry added a commit that referenced this pull request Dec 29, 2024
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
NathanFlurry added a commit that referenced this pull request Dec 29, 2024
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Dec 29, 2024
@graphite-app graphite-app bot deleted the 12-27-fix_toolchain_fix_js-utils_build_paths_on_windows branch December 29, 2024 07:15
Copy link

linear bot commented Dec 30, 2024

RVT-4491 Test windows

Copy link

linear bot commented Dec 30, 2024

@NathanFlurry NathanFlurry linked an issue Dec 30, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't deploy rivet init project
1 participant