Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: github star button #1851

Closed
wants to merge 1 commit into from
Closed

feat: github star button #1851

wants to merge 1 commit into from

Conversation

NicholasKissel
Copy link
Member

@NicholasKissel NicholasKissel commented Jan 16, 2025 •
edited
Loading

Closes WEB-252

Changes

image.png

image.png

@NicholasKissel Graphite App
Copy link
Member Author

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NicholasKissel NicholasKissel marked this pull request as ready for review January 16, 2025 18:11
@linear Linear
Copy link

linear bot commented Jan 16, 2025

WEB-252 Add embed GitHub stars button to landing page

NathanFlurry
NathanFlurry previously requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts on puttin gthe discord icon in a square (without text) too? just so we don't have 3 different butotn styles, looks odd. also horizontal spacing feels too high

jog1t
jog1t approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jog1t jog1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff30b3c
Status: ✅  Deploy successful!
Preview URL: https://2384b409.rivet.pages.dev
Branch Preview URL: https://01-16-feat-github-star-butto.rivet.pages.dev

View logs

@NathanFlurry Graphite App
Copy link
Member

eh yeah maybe discord doesn't need a square, just an idea. can we shrink the horizontal spacing between these two buttons:

CleanShot 2025-01-16 at 10.17.01@2x.png

@NicholasKissel Graphite App
Copy link
Member Author

thoughts on puttin gthe discord icon in a square (without text) too? just so we don't have 3 different butotn styles, looks odd. also horizontal spacing feels too high

image.png

@NicholasKissel Graphite App
Copy link
Member Author

eh yeah maybe discord doesn't need a square, just an idea. can we shrink the horizontal spacing between these two buttons:

CleanShot 2025-01-16 at 10.17.01@2x.png

Added via Giphy

@NicholasKissel Graphite App
Copy link
Member Author

image.png

@NathanFlurry

@NicholasKissel NicholasKissel force-pushed the 01-16-feat_github_star_button branch from b5acd2e to ff30b3c Compare January 16, 2025 18:26
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jan 16, 2025 •
edited
Loading

Merge activity

  • Jan 16, 1:51 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 16, 1:51 PM EST: CI is running for this PR on a draft PR: #1852
  • Jan 16, 1:52 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1852.

NicholasKissel added a commit that referenced this pull request Jan 16, 2025
@NicholasKissel
feat: github star button (#1851)
65a9b2e 
Closes WEB-252
## Changes

<!-- If there are frontend changes, please include screenshots. -->

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/s4Iqp0cv660GaL4sSZTl/3c6aad1f-9eb8-4773-ba88-8b170c52e0ae.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/s4Iqp0cv660GaL4sSZTl/947a47eb-90ef-4db1-b3a9-6e91a6101c99.png)
@graphite-app graphite-app bot closed this Jan 16, 2025
@graphite-app graphite-app bot deleted the 01-16-feat_github_star_button branch January 16, 2025 18:52
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jog1t jog1t jog1t approved these changes

@NathanFlurry NathanFlurry NathanFlurry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasKissel @NathanFlurry @jog1t