Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add internal api monolith #641

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

MasterPtato
Copy link
Contributor

Changes

Copy link
Contributor Author

MasterPtato commented Apr 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be backwards compatible to support gg nodes with the old request config still on it.

this includes both:

  • the hostsni route
  • the path

tbh we could rename it to api-traefik to keep the path consistent for now.

Copy link
Contributor Author

MasterPtato commented Apr 9, 2024

@NathanFlurry Could you elaborate? There are no old gg nodes, you can't migrate from the old pools to new server provisioning

Copy link
Member

@NathanFlurry Could you elaborate? There are no old gg nodes, you can't migrate from the old pools to new server provisioning

Ah right, my bad.

Since we're reworking this in this PR, can we rename api-route to api-traefik-provider? so the full route is just/traefik-provider/config (instead of /route/traefik/config). i think it's clearer what it actually does.

@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from 891f3b1 to 281f968 Compare April 15, 2024 21:42
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 8ce9ff6 to 54cfeeb Compare April 15, 2024 21:42
@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from 281f968 to 80cfc06 Compare April 15, 2024 21:56
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 54cfeeb to 183faad Compare April 15, 2024 21:56
@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from 80cfc06 to f7ca7f0 Compare April 16, 2024 00:08
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 183faad to 1a5453f Compare April 16, 2024 00:08
Copy link
Contributor

graphite-app bot commented Apr 17, 2024

Merge activity

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants