Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run sub workflows in the same process #789

Merged
merged 1 commit into from
Jun 5, 2024
Merged

feat: run sub workflows in the same process #789

merged 1 commit into from
Jun 5, 2024

Conversation

MasterPtato
Copy link
Contributor

Changes

This was referenced May 9, 2024
Merged
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented May 9, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced May 9, 2024
Merged
Merged
Merged
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented May 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

@MasterPtato MasterPtato mentioned this pull request May 9, 2024
Merged
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from e680469 to 9b451f4 Compare May 9, 2024 23:43
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch 3 times, most recently from c79f1e3 to c2e65f1 Compare May 10, 2024 17:46
NathanFlurry
NathanFlurry requested changes May 16, 2024
View reviewed changes
lib/chirp-workflow/core/src/ctx/workflow.rs Outdated Show resolved Hide resolved
lib/chirp-workflow/core/src/ctx/workflow.rs Outdated Show resolved Hide resolved
lib/chirp-workflow/core/src/ctx/workflow.rs Outdated Show resolved Hide resolved
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 9b451f4 to 4cc6aa8 Compare May 16, 2024 23:38
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from c2e65f1 to 8a824eb Compare May 16, 2024 23:38
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 4cc6aa8 to c456d1a Compare May 17, 2024 00:10
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from 8a824eb to adfd591 Compare May 17, 2024 00:10
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from c456d1a to 5554b1d Compare May 17, 2024 00:39
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from adfd591 to 4055ea7 Compare May 17, 2024 00:39
@MasterPtato MasterPtato requested a review from NathanFlurry May 17, 2024 20:25
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 5554b1d to 0df5e9d Compare May 17, 2024 20:25
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from 4055ea7 to eefac27 Compare May 17, 2024 20:26
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 0df5e9d to 2fb1526 Compare May 30, 2024 16:44
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from eefac27 to 4fdb385 Compare May 30, 2024 16:44
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 2fb1526 to 9f1ead6 Compare June 4, 2024 18:53
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from 4fdb385 to 21fc035 Compare June 4, 2024 18:53
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from 21fc035 to 6a0c6ba Compare June 4, 2024 20:39
@MasterPtato MasterPtato mentioned this pull request Jun 4, 2024
Merged
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 9f1ead6 to 895eaee Compare June 4, 2024 20:46
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from 6a0c6ba to a3511ca Compare June 4, 2024 20:46
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 895eaee to 2e3b4ca Compare June 4, 2024 21:59
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from a3511ca to 4308e3d Compare June 4, 2024 22:00
@MasterPtato MasterPtato mentioned this pull request Jun 5, 2024
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jun 5, 2024 •
edited
Loading

Merge activity

@MasterPtato
feat: run sub workflows in the same process (#789)
717e096 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@MasterPtato MasterPtato force-pushed the 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows branch from 2e3b4ca to 787971b Compare June 5, 2024 20:17
@MasterPtato MasterPtato force-pushed the 05-09-feat_run_sub_workflows_in_the_same_process branch from 4308e3d to 717e096 Compare June 5, 2024 20:18
@MasterPtato MasterPtato changed the base branch from 05-09-feat_add_compat_layer_between_old_ctx_and_new_workflows to main June 5, 2024 20:27
@graphite-app graphite-app bot merged commit 717e096 into main Jun 5, 2024
6 of 10 checks passed
@graphite-app graphite-app bot deleted the 05-09-feat_run_sub_workflows_in_the_same_process branch June 5, 2024 20:27
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

@AngelOnFira AngelOnFira Awaiting requested review from AngelOnFira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MasterPtato @NathanFlurry @AngelOnFira