Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bolt): add k9s to nix-shell #903

Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat(bolt): add k9s to nix-shell #903

merged 1 commit into from
Jul 23, 2024

Conversation

AngelOnFira
Copy link
Contributor

Changes

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jun 11, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
@AngelOnFira Graphite App
Copy link
Contributor Author

AngelOnFira commented Jun 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AngelOnFira and the rest of your teammates on Graphite Graphite

This was referenced Jun 11, 2024
Merged
Closed
@AngelOnFira AngelOnFira force-pushed the 04-24-feat_svc_add_servers_create_endpoint branch from b629022 to cf2324c Compare June 12, 2024 21:00
@AngelOnFira AngelOnFira force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from 9831825 to 8fb3c75 Compare June 12, 2024 21:01
NathanFlurry
NathanFlurry requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just add the alias, not the k9s dependency. trying to keep our nix deps as lightweight as possible, since that directly adds wait time for setting up a dev env.

@AngelOnFira AngelOnFira force-pushed the 04-24-feat_svc_add_servers_create_endpoint branch from cf2324c to 1004e40 Compare June 18, 2024 01:17
@AngelOnFira AngelOnFira force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from 8fb3c75 to 9ec01b3 Compare June 18, 2024 01:17
@AngelOnFira AngelOnFira mentioned this pull request Jun 18, 2024
Closed
@NathanFlurry
Copy link
Member

NathanFlurry commented Jun 18, 2024 •
edited
Loading

@AngelOnFira can you move #904 on to #740 or address the comment above

@NathanFlurry NathanFlurry reopened this Jun 18, 2024
@AngelOnFira AngelOnFira force-pushed the 04-24-feat_svc_add_servers_create_endpoint branch from 1004e40 to 40f3adb Compare June 25, 2024 03:58
@AngelOnFira AngelOnFira force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from 9ec01b3 to c273f89 Compare June 25, 2024 03:58
@AngelOnFira AngelOnFira force-pushed the 04-24-feat_svc_add_servers_create_endpoint branch from 40f3adb to 4e6f9bd Compare June 26, 2024 19:09
@AngelOnFira AngelOnFira force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from c273f89 to 793ca7b Compare June 26, 2024 19:09
This was referenced Jun 26, 2024
Closed
Merged
@AngelOnFira AngelOnFira force-pushed the 04-24-feat_svc_add_servers_create_endpoint branch from 4e6f9bd to df39060 Compare June 26, 2024 21:56
@NathanFlurry NathanFlurry force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from ef0d921 to 86b2b21 Compare July 3, 2024 09:37
@NathanFlurry Graphite App
Copy link
Member

@AngelOnFira we can merge this if we remove k9s from the packages and just leave the alias. if you install it on the host system, k9s will work as expected.

@AngelOnFira Graphite App
Copy link
Contributor Author

Oh ya, now that I'm not in a devcontainer that will be dope

@AngelOnFira AngelOnFira marked this pull request as ready for review July 3, 2024 20:01
AngelOnFira
AngelOnFira commented Jul 3, 2024
View reviewed changes
shell.nix Outdated Show resolved Hide resolved
@AngelOnFira AngelOnFira requested a review from NathanFlurry July 3, 2024 20:30
@NathanFlurry NathanFlurry force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from 357f920 to d1b740e Compare July 3, 2024 22:03
@NathanFlurry NathanFlurry changed the base branch from 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script to 07-03-feat_runtime_switch_from_json_to_logfmt July 3, 2024 22:03
@NathanFlurry NathanFlurry requested a review from MasterPtato July 3, 2024 22:03
@NathanFlurry NathanFlurry mentioned this pull request Jul 3, 2024
Merged
@AngelOnFira AngelOnFira force-pushed the 07-03-feat_runtime_switch_from_json_to_logfmt branch from 7178501 to a5bde01 Compare July 4, 2024 00:31
@AngelOnFira AngelOnFira force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from d1b740e to bc8ad50 Compare July 4, 2024 00:31
@NathanFlurry NathanFlurry force-pushed the 07-03-feat_runtime_switch_from_json_to_logfmt branch from a5bde01 to eba763c Compare July 4, 2024 18:41
@NathanFlurry NathanFlurry force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from bc8ad50 to e937235 Compare July 4, 2024 18:41
@NathanFlurry NathanFlurry mentioned this pull request Jul 4, 2024
Merged
@AngelOnFira AngelOnFira force-pushed the 07-03-feat_runtime_switch_from_json_to_logfmt branch from eba763c to 2793134 Compare July 6, 2024 04:19
@AngelOnFira AngelOnFira force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from e937235 to 2654335 Compare July 6, 2024 04:19
@NathanFlurry NathanFlurry force-pushed the 07-03-feat_runtime_switch_from_json_to_logfmt branch from 2793134 to eba763c Compare July 6, 2024 17:52
@NathanFlurry NathanFlurry force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from 2654335 to e937235 Compare July 6, 2024 17:52
@NathanFlurry NathanFlurry mentioned this pull request Jul 23, 2024
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jul 23, 2024 •
edited
Loading

Merge activity

@AngelOnFira
feat(bolt): add k9s to nix-shell (#903)
7668942 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 07-03-feat_runtime_switch_from_json_to_logfmt branch from eba763c to 10a0e6c Compare July 23, 2024 08:13
@NathanFlurry NathanFlurry force-pushed the 06-11-feat_bolt_add_k9s_to_nix-shell branch from e937235 to 7668942 Compare July 23, 2024 08:13
@NathanFlurry NathanFlurry changed the base branch from 07-03-feat_runtime_switch_from_json_to_logfmt to main July 23, 2024 08:22
@graphite-app graphite-app bot merged commit 7668942 into main Jul 23, 2024
6 of 10 checks passed
@graphite-app graphite-app bot deleted the 06-11-feat_bolt_add_k9s_to_nix-shell branch July 23, 2024 08:23
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AngelOnFira @NathanFlurry @MasterPtato