Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the rust-embedded/riscv crate for CSR access #95

Open
abrestic-rivos opened this issue Sep 9, 2022 · 1 comment
Open

Comments

@abrestic-rivos
Copy link
Collaborator

Consider using the officially-supported riscv crate for CSR access rather than our local fork of Tock's riscv-csr crate. We'd need to upstream a bunch of changes to the former as it's missing most of the S/HS/VS CSRs that we care about in Salus.

cc @FawazTirmizi

@FawazTirmizi
Copy link

There is a fork of the riscv crate in our organization as well (here). We (firmware) were planning on adding S-mode CSRs ourselves at some point anyways so I'm happy to take care of that. For hypervisor-related stuff, adding the new registers should also be a straightforward task, but likely not as high of a priority for us.

It may be possible to switch the crate to using the interfaces from riscv-csr if that'd be preferable, but I think we should see what upstream thinks of that before going with that option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants