Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyCC failing debugging tests #398

Closed
XVilka opened this issue Jan 20, 2021 · 2 comments
Closed

TinyCC failing debugging tests #398

XVilka opened this issue Jan 20, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers RzDebug

Comments

@XVilka
Copy link
Member

XVilka commented Jan 20, 2021

Work environment

Questions Answers
OS/arch/bits (mandatory) Ubuntu x86_64
File format of the file you reverse (mandatory) ELF
Architecture/bits of the file (mandatory) x86/64
rizin -v full output, not truncated (mandatory) 06d194b

Expected behavior

All tests pass on the Ubuntu

Actual behavior


[XX] db/archos/linux-x64/dbg_maps dbg.maps.count.after.map
RZ_NOPLUGINS=1 rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -d -Qc 'dm~?
db sym.imp.puts
dc~?
dm~?
dc
' bins/elf/analysis/x86-helloworld-gcc
-- stdout
@@ -1,4 +1,4 @@
-9
+7
 0
-17
+13
 Hello world!


-- stderr
Process with PID 19064 started...
= attach 19064 19064
bin.baddr 0x08048000
Using 0x8048000
asm.bits 32
glibc.fc_offset = 0x00148
hit breakpoint at: 0x80482d0
(19064) Process exited with status=0x0



[XX] db/archos/linux-x64/dbg_maps dbg.maps.count
RZ_NOPLUGINS=1 rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -d -Qc 'dm~?
dk 9
' bins/elf/analysis/elf-nx
-- stdout
@@ -1 +1 @@
-9
+7


-- stderr
Process with PID 19081 started...
= attach 19081 19081
bin.baddr 0x08048000
Using 0x8048000
asm.bits 32
glibc.fc_offset = 0x00148



[XX] db/archos/linux-x64/dbg_maps dbg.maps.count/
RZ_NOPLUGINS=1 rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -d -Qc 'dm~?/
dk 9
' bins/elf/analysis/elf-nx
-- stdout
@@ -1 +1 @@
-6
+4


-- stderr
Process with PID 19083 started...
= attach 19083 19083
bin.baddr 0x08048000
Using 0x8048000
asm.bits 32
glibc.fc_offset = 0x00148

It might be the sign of some compiler-dependent logic/code. We don't catch it with MSVC because those tests run only on Linux, and both GCC and Clang often replicate each other's behavior. cc @yossizap

See logs at https://github.com/rizinorg/rizin/runs/2270610728#step:12:701

@XVilka XVilka added bug Something isn't working good first issue Good for newcomers RzDebug labels Jan 20, 2021
@XVilka XVilka changed the title TinyCC failing debuggin tests TinyCC failing debugging tests Jan 20, 2021
@XVilka XVilka added this to the 0.2.0 milestone Jan 22, 2021
@XVilka XVilka modified the milestones: 0.2.0, 0.3.0 Mar 1, 2021
@XVilka
Copy link
Member Author

XVilka commented Apr 6, 2021

Updated the issue, now only 3 debug tests are broken with TinyCC.

@ret2libc ret2libc removed this from the 0.3.0 milestone Apr 23, 2021
@XVilka
Copy link
Member Author

XVilka commented Aug 10, 2021

It was fixed in the latest dev: https://github.com/rizinorg/rizin/runs/3287509910#step:12:749

In the #1414 I will enable TinyCC tests to be checked again.

@XVilka XVilka closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers RzDebug
Projects
Status: Done
Development

No branches or pull requests

2 participants