Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out the ah* commands #698

Closed
XVilka opened this issue Feb 24, 2021 · 5 comments
Closed

Sort out the ah* commands #698

XVilka opened this issue Feb 24, 2021 · 5 comments

Comments

@XVilka
Copy link
Member

XVilka commented Feb 24, 2021

Work environment

Questions Answers
OS/arch/bits (mandatory) -
File format of the file you reverse (mandatory) -
Architecture/bits of the file (mandatory) -
rizin -v full output, not truncated (mandatory) d4638fe

Currently we have two duplicate commands, two of them marked as "deprecated". We need to figure out if something is missing in non-deprecated one, implement it, and remove the rest.
Note, that they serve somewhat different purpose and might not be deprecated at all.

Expected behavior

Only one command should stay

Actual behavior

| ahd foo a0,33      replace opcode string
| aho call           change opcode type (see aho?) (deprecated, moved to "ahd")
| aht [?] <type>     Mark immediate as a type offset (deprecated, moved to "aho")

After the change also tests should be updated and added if necessary.

@XVilka XVilka added this to the 0.2.0 milestone Feb 24, 2021
@XVilka XVilka modified the milestones: 0.2.0, 0.3.0 Mar 1, 2021
@XVilka XVilka modified the milestones: 0.3.0, 0.4.0 Jul 5, 2021
@stale
Copy link

stale bot commented Jan 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has probably changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of rizin. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 7, 2022
@DMaroo
Copy link
Member

DMaroo commented Jan 7, 2022

Did #2130 fix it or not?

@stale stale bot removed the stale label Jan 7, 2022
@ret2libc
Copy link
Member

ret2libc commented Jan 8, 2022

Did #2130 fix it or not?

I don't think it does. @pelijah do you know whether the commands listed in this issue really do different things or if some of them should be removed?

@pelijah
Copy link
Contributor

pelijah commented Jan 8, 2022

They all work but aho is not covered by tests.

@ret2libc
Copy link
Member

ret2libc commented Jan 8, 2022

Ok, thanks pelijah. Let's close this then.

@ret2libc ret2libc closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants