Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar icons and DPI scaling #563

Closed
douglangille opened this issue Jul 30, 2018 · 15 comments
Closed

Toolbar icons and DPI scaling #563

douglangille opened this issue Jul 30, 2018 · 15 comments

Comments

@douglangille
Copy link

I'm using a laptop that requires DPI scaling. The icons on the toolbar do not scale and look teeny-tiny.

Computer: Dell Latitude 5285
Physical resolution: 1920x1280
Scaling: 150% (Microsoft-recommended setting)

capture

@zufuliu
Copy link

zufuliu commented Jul 30, 2018

@douglangille Can you also try Notepad2 from https://github.com/zufuliu/notepad2/releases?

@craigo-
Copy link

craigo- commented Jul 31, 2018

@douglangille:

  1. What version of Notepad3 are you using?
  2. Have you tried toggling the "HighDPI Toolbar" setting under the Tools menu?

@zufuliu
Copy link

zufuliu commented Jul 31, 2018

@douglangille
This issue XhmikosR/notepad2-mod#175 may help to get better experience on High DIP monitor.

@douglangille
Copy link
Author

@zufuliu

  • issue exists in Notepad2 and the fix you linked to probably would help
    @craigo-
  1. using the latest released build.
  2. View | HighDPI Toolbar is indeed a suitable workaround, though this should probably be automagic.

Thanks for your help folks.

@RaiKoHoff
Copy link
Collaborator

Please test beta (see #160) development version _X_MUI_4.18.802.1034.

@hpwamr
Copy link
Collaborator

hpwamr commented Aug 2, 2018

Hello @douglangille
Feel free to test this beta version "development version _X_MUI_4.18.802.1035" with HightDPI enhancements.
Notepad3Portable_4.18.802.1035.7z (Download link valid till: 9 August, 2018).

@hpwamr
Copy link
Collaborator

hpwamr commented Aug 2, 2018

Hello @RaiKoHoff , @douglangille

After a test with a "Display scaling to 150%", I confirm that now the "Icons bar" is scaled too! 👍 😄

np3_display_150

Tested with : Notepad3 (64-bit) X_MUI v4.18.802.1034
Issue corrected. 👍 ❤️
As far as I am concerned, this issue may be stay closed....

@RaiKoHoff
Copy link
Collaborator

@hpwamr : The Text Font Scaling (line numbering and document text) will been changed too - tests are appreciated 😉

@hpwamr
Copy link
Collaborator

hpwamr commented Aug 2, 2018

@RaiKoHoff It seems that all areas are changing correctly. 😉

DPI 100%
np3_100

DPI 125%
np3_125

DPI 150%
np3_150

DPI 175%
np3_175

@RaiKoHoff
Copy link
Collaborator

@hpwamr : 👍 , did you check Help dialog and Bookmark & Folding Margin area too?
(Latest beta is _X_MUI_4.18.802.1035 😉 )

@hpwamr
Copy link
Collaborator

hpwamr commented Aug 2, 2018

@RaiKoHoff , Tested with : Notepad3 (64-bit) X_MUI v4.18.802.1035 - with DPI 150%

  • All functions seems to work correctly.
  • Dialog box of "Customize Schemes" is lightly perturbed (but acceptable)

About box: to show correctly a user Sign Out is needed.

  • a part of the text is claiming a "log_out/Log_in" to reflect the correct scaling
  • position of NP3 icon is not correct

NP3_v1035_Scaling_150%.zip

@RaiKoHoff
Copy link
Collaborator

Regarding DPI Awareness of current development beta version _TinyExpr_4.18.820.1062:
The Toolbar icons are scaled too, regardless which ones (normal or HighDPI icons).
Maybe it would make sense to scale the HigDPI icons only if a certain DPI value is exceeded?
Suggestions?

@RaiKoHoff RaiKoHoff reopened this Aug 20, 2018
@zufuliu
Copy link

zufuliu commented Aug 20, 2018

@RaiKoHoff Notepad2 only has one lower DPI toolbar image, so I have no choice.
I think you need chose the HighDPI image to scale up or down when current DPI is above some threshold. You can hard-coded g_uCurrentDPI to some value and see the resize result.

@RaiKoHoff
Copy link
Collaborator

A special behavior for DPI scaling of HighDPI toolbar is implemented:
The HighDPI toolbar is not scaled (to avoid blurry effects from aliasing due to scaled rendering) until a certain threshold (144 = 3/2 of std. DPI (96)) is exceeded - then, the HighDPI is scaled too, which causes a "sizing jump" of the toolbar on small step (144 -> 145 DPI).

@hpwamr
Copy link
Collaborator

hpwamr commented Dec 10, 2018

As far as I am concerned, this issue may be closed....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants