-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New map module based on MapLibre #441
Comments
You don't need to replace something that works - there is no problem adding another module. |
Good point! I assumed that having two kvision-map modules would be awkward, so one would replace the other. Do you know if the the current kvision-map module well used? |
I'm using the module in one of my apps, but it's very simple usage (just to show a location of the entity). Maven central stats show about 1K downloads a month, even though it's not included by default in any template or example app. |
This is a very speculative issue,
https://maplibre.org/
I like the look of MapLibre for a couple of reasons:
Generally it looks like MapLibre is less popular (it's much newer, having been recently split from MapBox, after a license change), but it supports more modern features.
Implementing MapLibre bindings is made much more difficult because Dukat fails to generate anything Kotlin/dukat#477. By comparison, Dukat did generate most of the Leaflet bindings, which provided a good basis. However... those aren't perfect because Leaflet is not TypeScript native (unlike MapLibre), so the TypeScript the Leaflet bindings were generated from might not be accurate (but they seem to work okay). So it's a mixed bag. Anyway, defining new bindings is a lot of work, regardless of Dukat support.
There is some interest in creating Kotlin bindings for MapBox/MapLibre Kotlin/dukat#477. Additional it looks like there's some movement to migrate the MapLibre's Java code to Kotlin maplibre/maplibre-native#420 - so maybe MapLibre devs could help with the bindings? Or even include them themselves? I might make an issue.
I'm not likely to pick this up any time soon - Leaflet is good enough. But if there's a lot of support, or someone wants to collaborate, I could give it a go.
The text was updated successfully, but these errors were encountered: