Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 8.0.0-RC #537

Closed
pambrose opened this issue Aug 22, 2024 · 10 comments
Closed

Issue with 8.0.0-RC #537

pambrose opened this issue Aug 22, 2024 · 10 comments

Comments

@pambrose
Copy link

When trying to upgrade to 8.0.0-RC, I am seeing the same issue in the address-fullstack-ktor example and my own code. When I do a build on address-fullstack-ktor I get:

e: file:///git/kvision-examples/addressbook-fullstack-ktor/build/generated/ksp/metadata/commonMain/kotlin/com/example/AddressService.kt:10:8 Class 'AddressService' is not abstract and does not implement abstract member 'getAddressList'.
e: file:///git/kvision-examples/addressbook-fullstack-ktor/build/generated/ksp/metadata/commonMain/kotlin/com/example/ProfileService.kt:10:8 Class 'ProfileService' is not abstract and does not implement abstract member 'getProfile'.
e: file:///git/kvision-examples/addressbook-fullstack-ktor/build/generated/ksp/metadata/commonMain/kotlin/com/example/RegisterProfileService.kt:10:8 Class 'RegisterProfileService' is not abstract and does not implement abstract member 'registerProfile'

Thanks.

@rjaros
Copy link
Owner

rjaros commented Aug 22, 2024

That's strange. I've tested all the examples and they are building without problems on my machine. I've also upgraded some other apps without such issues as well.

@pambrose
Copy link
Author

Interesting!!
I tried Java 11, 17, and 21 and all 3 had the same issue. I invoked build from the CLI and IJ.
Let me try it on a different machine.

@rjaros
Copy link
Owner

rjaros commented Aug 22, 2024

Have you fresh cloned kvision-examples repo?

@pambrose
Copy link
Author

I do.
My original problem was on OSX. I just went to a Linux box and did a fresh clone and a build on address-fullstack-ktor and I got the same errors.
This is really bizarre!

@pambrose
Copy link
Author

I got a similar error in numbers-fullstack-ktor:
e: file:///git/kvision-examples/numbers-fullstack-ktor/build/generated/ksp/metadata/commonMain/kotlin/com/example/NumberService.kt:10:8 Class 'NumberService' is not abstract and does not implement abstract member 'numberToWords'.

@rjaros
Copy link
Owner

rjaros commented Aug 22, 2024

Please compare your commands and console output:

rjaros@rjaros1:~/temp$ git clone git@github.com:rjaros/kvision-examples.git
Klonowanie do „kvision-examples”...
remote: Enumerating objects: 21159, done.
remote: Counting objects: 100% (2464/2464), done.
remote: Compressing objects: 100% (411/411), done.
remote: Total 21159 (delta 1996), reused 2440 (delta 1978), pack-reused 18695 (from 1)
Pobieranie obiektów: 100% (21159/21159), 185.51 MiB | 3.77 MiB/s, gotowe.
Rozwiązywanie delt: 100% (15137/15137), gotowe.
rjaros@rjaros1:~/temp$ cd kvision-examples/addressbook-fullstack-ktor
rjaros@rjaros1:~/temp/kvision-examples/addressbook-fullstack-ktor$ ./gradlew jar

> Configure project :
w: 'java' Gradle plugin is not compatible with 'org.jetbrains.kotlin.multiplatform' plugin.

Consider adding a new subproject with 'java' plugin where the KMP project is added as a dependency.


> Task :kotlinNpmInstall
(node:45014) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
warning gettext-extract > gettext-extractor > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning gettext-extract > gettext-extractor > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning workspace-aggregator-27320d97-5362-4abe-80b9-51e5a17b1ff6 > addressbook-fullstack-ktor-test > karma > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning workspace-aggregator-27320d97-5362-4abe-80b9-51e5a17b1ff6 > addressbook-fullstack-ktor-test > mocha > glob@8.1.0: Glob versions prior to v9 are no longer supported
warning workspace-aggregator-27320d97-5362-4abe-80b9-51e5a17b1ff6 > addressbook-fullstack-ktor-test > mocha > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning workspace-aggregator-27320d97-5362-4abe-80b9-51e5a17b1ff6 > addressbook-fullstack-ktor-test > karma-webpack > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning workspace-aggregator-27320d97-5362-4abe-80b9-51e5a17b1ff6 > addressbook-fullstack-ktor-test > karma > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning workspace-aggregator-27320d97-5362-4abe-80b9-51e5a17b1ff6 > addressbook-fullstack-ktor-test > karma > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning chart.js@4.4.3: The engine "pnpm" appears to be invalid.
warning " > style-loader@4.0.0" has unmet peer dependency "webpack@^5.27.0".
warning " > imports-loader@5.0.0" has unmet peer dependency "webpack@^5.0.0".
warning "gettext.js > po2json@1.0.0-beta-3" has unmet peer dependency "commander@^6.0.0".
warning "gettext.js > po2json@1.0.0-beta-3" has unmet peer dependency "gettext-parser@2.0.0".
warning "gettext.js > po2json@1.0.0-beta-3" has unmet peer dependency "gettext-to-messageformat@0.3.1".
warning " > karma-junit-reporter@2.0.1" has unmet peer dependency "karma@>=0.9".
warning Ignored scripts due to flag.

> Task :compileKotlinJvm
w: file:///opt/rjaros/temp/kvision-examples/addressbook-fullstack-ktor/src/jvmMain/kotlin/com/example/Service.kt:28:11 This code uses error suppression for 'ACTUAL_WITHOUT_EXPECT'. While it might compile and work, the compiler behavior is UNSPECIFIED and WON'T BE PRESERVED. Please report your use case to the Kotlin issue tracker instead: https://kotl.in/issue
w: file:///opt/rjaros/temp/kvision-examples/addressbook-fullstack-ktor/src/jvmMain/kotlin/com/example/Service.kt:148:11 This code uses error suppression for 'ACTUAL_WITHOUT_EXPECT'. While it might compile and work, the compiler behavior is UNSPECIFIED and WON'T BE PRESERVED. Please report your use case to the Kotlin issue tracker instead: https://kotl.in/issue
w: file:///opt/rjaros/temp/kvision-examples/addressbook-fullstack-ktor/src/jvmMain/kotlin/com/example/Service.kt:158:11 This code uses error suppression for 'ACTUAL_WITHOUT_EXPECT'. While it might compile and work, the compiler behavior is UNSPECIFIED and WON'T BE PRESERVED. Please report your use case to the Kotlin issue tracker instead: https://kotl.in/issue

> Task :jsBrowserProductionWebpack
asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets: 
  07ed6d5fa32c1d54af0f.ttf (414 KiB)

webpack performance recommendations: 
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/


BUILD SUCCESSFUL in 48s
25 actionable tasks: 25 executed
rjaros@rjaros1:~/temp/kvision-examples/addressbook-fullstack-ktor$ java -jar build/libs/addressbook-fullstack-ktor-1.0.0-SNAPSHOT.jar 
[2024-08-22 19:12:24,103]-[main] INFO  Application - Autoreload is disabled because the development mode is off.
[2024-08-22 19:12:24,309]-[main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Starting...
[2024-08-22 19:12:24,413]-[main] INFO  com.zaxxer.hikari.HikariDataSource - HikariPool-1 - Start completed.
[2024-08-22 19:12:24,737]-[main] INFO  Application - Application started in 0.656 seconds.
[2024-08-22 19:12:24,737]-[main] INFO  Application - Application started: io.ktor.server.application.Application@15eb0ae9
[2024-08-22 19:12:24,827]-[DefaultDispatcher-worker-1] INFO  Application - Responding at http://0.0.0.0:8080
^C[2024-08-22 19:12:28,264]-[KtorShutdownHook] INFO  Application - Application stopping: io.ktor.server.application.Application@15eb0ae9
[2024-08-22 19:12:28,272]-[KtorShutdownHook] INFO  Application - Application stopped: io.ktor.server.application.Application@15eb0ae9
rjaros@rjaros1:~/temp/kvision-examples/addressbook-fullstack-ktor$ 

@rjaros
Copy link
Owner

rjaros commented Aug 22, 2024

rjaros@rjaros1:~/temp/kvision-examples/addressbook-fullstack-ktor$ java -version
openjdk version "17.0.12" 2024-07-16
OpenJDK Runtime Environment (Red_Hat-17.0.12.0.7-2) (build 17.0.12+7)
OpenJDK 64-Bit Server VM (Red_Hat-17.0.12.0.7-2) (build 17.0.12+7, mixed mode, sharing)

@pambrose
Copy link
Author

pambrose commented Aug 22, 2024

Sorry, I am a dope. I was using build and not jar. Sorry for wasting your time. All good.

@rjaros
Copy link
Owner

rjaros commented Aug 22, 2024

Still that's interesting why the compileCommonMainKotlinMetadata task (executed by build) is failing. It seem to fail on compiling Kotlin file, which obviously is correct.

@rjaros
Copy link
Owner

rjaros commented Aug 22, 2024

I've asked a question in the slack channel. Perhaps someone will explain the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants