-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form becomes unresponsive when "liveOmit" and "omitExtraData" props are turned on for schemas containing fixed array of objects #3909
Comments
@epicfaace Would like to contribute here. Don't have the permission to push the branch though. Can you please help here. |
@heath-freenome @nickgros Please check this. |
@Rozamo thanks for the report. This is definitely a bad bug! Do you have any time to investigate this? We would be happy to help point you to likely places in code and review a PR. |
@nickgros Yes, I do. I have identified the issue and made changes in my local repo. But I am unable to push the branch to remote. Can you please help with the permission. |
@Rozamo You can create a forked repository in GitHub and push your changes to your forked repo. You can then open a pull request comparing the branch on your forked repo to the RJSF main branch |
Hi @heath-freenome, I wonder if these changes were really necessary. The JSON schema looked incorrect from the start because you can't use an array to define "items". According to the JSON Schema specification "The value of "items" MUST be a valid JSON Schema" (https://json-schema.org/draft/2020-12/json-schema-core#section-10.3.1.2) and "A JSON Schema MUST be an object or a boolean” (https://json-schema.org/draft/2020-12/json-schema-core#section-4.3). I had to go back to a version before this change because my JSON schemas stopped working after that. Here is an example of a schema that stopped working after this change (it works fine with the previous version of the package) - rjsf playground. You can see that otherProperty is rendered correctly according to the if...then condition and is correctly validated, so the JSON schema is correct. However, you cannot change the value of this property when the |
@anya92 Not sure if the issue you're facing is related to this fix. I tried the schema that you provided in the earlier version (15.13.2) and it's not working there either. Also, the schema provided in the issue description is correct according to the draft 07 version which is the default used in rjsf. Please check the |
@anya92 Can you create an issue for this? Please reference this thread |
Prerequisites
What theme are you using?
core
Version
5.13.2
Current Behavior
I am using the following schema in the playground with
liveOmit
andomitExtraData
turned onUpon typing anything in the
title
input box, the focus shifts away from the input box and there is no change in the input box or the form dataExpected Behavior
The data entered should be reflected in the
title
input box and the form data.Steps To Reproduce
liveOmit
andomitExtraData
propstitle
input boxEnvironment
Anything else?
The text was updated successfully, but these errors were encountered: