Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation Fault on changing function params #3

Open
mwbryant opened this issue Aug 4, 2022 · 2 comments
Open

Segmentation Fault on changing function params #3

mwbryant opened this issue Aug 4, 2022 · 2 comments

Comments

@mwbryant
Copy link

mwbryant commented Aug 4, 2022

Running on Ubuntu 20.04

When testing out the bevy example, if I add commands to the parameters for player_movement_system then the application seg faults. This happens for any change to the system params I have tested. This may be a fundamental limitation with these techniques though.

@rksm
Copy link
Owner

rksm commented Aug 4, 2022

Yeah exactly, with the current implementation this is unavoidable. The executable expects the library function signatures to be fixed, if they change you'll hit undefined behavior.

The most practical workaround for now is to either pass a larger state parameter that likely includes what you'll want to work with on the library side or start out providing potentially needed but not yet used parameters while developing a system.

I'll be looking into ideas of making this more flexible and do welcome suggestions to solve this problem. I'll leave this issue open for a discussion around that.

@mwbryant
Copy link
Author

mwbryant commented Aug 4, 2022

I'll be reading through your write-up and the code tonight. I love this idea and I think it can grow into a very powerful dev tool for bevy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants