Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitString can be decoded but not encoded #63

Open
seimnseimn opened this issue Jun 17, 2019 · 4 comments
Open

BitString can be decoded but not encoded #63

seimnseimn opened this issue Jun 17, 2019 · 4 comments

Comments

@seimnseimn
Copy link

BitString can be decoded but not encoded

29:syntax error token BitString

(I can supply example binary if needed)

@rlaager
Copy link
Owner

rlaager commented Jun 17, 2019

An example would be good. Patches are better. This project isn’t really getting much attention. I’m giving it a home, but I don’t use it.

@seimnseimn
Copy link
Author

Hi Richard,

to reproduce simply decode and encode below file. Unfortunately I'm not much of a c programmer. And it would take me quite some time to figure out how to patch this. On the other side I think this thing should have more stars as it is (to my knowledge) the only opensource and openly available docsis en-/decoder.

Have a nice day.

bits_test.cm.bin.zip

@spirit-t0aster
Copy link

I have a patch for this issue, how can I submit it?

@rlaager
Copy link
Owner

rlaager commented Oct 17, 2019

The best way would be a pull request. If you don’t know how to do a GitHub pull request, the gist is that you fork the repository, commit your changes on a branch, push that branch to your fork, and then it will give you a URL to create a pull request. If that sounds too complicated, you can paste the patch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants