Skip to content

Commit 5422de6

Browse files
committed
tag support, closes #8
1 parent 02f8143 commit 5422de6

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

lib/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ module.exports = function(config_hash) {
202202
app.put('/:package/:tag', can('publish'), media('application/json'), function(req, res, next) {
203203
if (typeof(req.body) !== 'string') return next('route')
204204

205-
storage.add_tag(req.params.name, req.body, req.params.tag, function(err) {
205+
storage.add_tag(req.params.package, req.body, req.params.tag, function(err) {
206206
if (err) return next(err)
207207
res.status(201)
208208
return res.send({
@@ -275,11 +275,11 @@ module.exports = function(config_hash) {
275275
// at this point document is either created or existed before
276276
var t1 = Object.keys(metadata._attachments)[0]
277277
create_tarball(t1, metadata._attachments[t1], function(err) {
278-
if (err) return err
278+
if (err) return next(err)
279279

280280
var t2 = Object.keys(metadata.versions)[0]
281281
create_version(t2, metadata.versions[t2], function(err) {
282-
if (err) return err
282+
if (err) return next(err)
283283

284284
res.status(201)
285285
return res.send({

lib/local-storage.js

+1
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ Storage.prototype.add_version = function(name, version, metadata, tag, callback)
227227

228228
Storage.prototype.add_tag = function(name, version, tag, callback) {
229229
var self = this
230+
230231
self.update_package(name, function updater(data, cb) {
231232
if (data.versions[version] == null) {
232233
return cb(new UError({

lib/middleware.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ module.exports.basic_auth = function basic_auth(callback) {
4242
function next(err) {
4343
// uncomment this to reject users with bad auth headers
4444
//return _next.apply(null, arguments)
45-
45+
4646
// swallow error, user remains unauthorized
4747
// set remoteUserError to indicate that user was attempting authentication
4848
if (err) req.remoteUserError = err.msg

lib/storage.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ Storage._merge_versions = function(local, up) {
404404

405405
// refresh dist-tags
406406
for (var i in up['dist-tags']) {
407-
utils.tag_version(local, i, up['dist-tags'][i])
407+
utils.tag_version(local, up['dist-tags'][i], i)
408408
}
409409
}
410410

lib/utils.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ module.exports.filter_tarball_urls = function(pkg, req, config) {
9090
return pkg
9191
}
9292

93-
module.exports.tag_version = function(data, tag, version) {
93+
module.exports.tag_version = function(data, version, tag) {
9494
if (tag === 'latest') return
9595
switch(typeof(data['dist-tags'][tag])) {
9696
case 'string':

0 commit comments

Comments
 (0)