nit: config assert() has no effect

[josephg]

https://github.com/rlidwka/sinopia/blob/master/lib/config.js#L33

assert(arg !== 'all' || arg !== 'owner' || arg !== 'anonymous' || arg !== 'undefined' || arg !== 'none', 'CONFIG: reserved user/uplink name: ' + arg)

Will always be true. Change || to &&.

[rlidwka]

I wonder, how did you find this error?

I'm trying to find an automated tool to check for things like this, but can't find one.

[josephg]

... Nothing fancy. I was just reading through some of the code.

[josephg]

... It does seem like the kind of thing you could do automated checks for, but I feel like the kind of people who make static analysers don't write javascript.