Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When pickling torch algorithms, move torch modules to CPU before pickling #2079

Open
avnishn opened this issue Sep 24, 2020 · 0 comments · May be fixed by #2270
Open

When pickling torch algorithms, move torch modules to CPU before pickling #2079

avnishn opened this issue Sep 24, 2020 · 0 comments · May be fixed by #2270
Assignees
Labels
bug Something isn't working pytorch
Milestone

Comments

@avnishn
Copy link
Member

avnishn commented Sep 24, 2020

Our current behavior is to pickle policies and value/q-functions so that they are pickled in their exact state, whether they are on gpu or not. This is bad because it forces users to use work-arounds to open torch pkled experiments on cpu only devices. A good example of this is when a user trains their policy on a server, but wants to see the policy in action, and they open it on their laptop, but their laptop doesn't have a gpu.

@avnishn avnishn added this to the v2020.10.0rc6 milestone Sep 24, 2020
@avnishn avnishn self-assigned this Sep 24, 2020
@ryanjulian ryanjulian modified the milestones: v2020.10.0rc7, v2020.10.0 Oct 14, 2020
@ryanjulian ryanjulian added the bug Something isn't working label Oct 14, 2020
@ziyiwu9494 ziyiwu9494 self-assigned this Apr 9, 2021
@ziyiwu9494 ziyiwu9494 linked a pull request Apr 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pytorch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants