Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug in PEARLWorker #2246

Open
eirik-thorp opened this issue Mar 5, 2021 · 0 comments · May be fixed by #2275
Open

Small bug in PEARLWorker #2246

eirik-thorp opened this issue Mar 5, 2021 · 0 comments · May be fixed by #2275

Comments

@eirik-thorp
Copy link

Hi!
I think there is a small bug in the PEARLWorker class for the PEARL algorithm.
The ´deterministic´ variable should specify if the action should be sampled from the action distribution or if the action should be the mean of the distribution, but in the current implementation the action is always sampled even if ´deterministic == True´.

https://github.com/rlworkgroup/garage/blob/master/src/garage/torch/algos/pearl.py#L742-L745
@krzentner krzentner linked a pull request May 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix double action sampling in PEARLWorker rlworkgroup/garage
1 participant
@eirik-thorp