Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero-length QUIC frames to be sent #67

Open
tomdedecker opened this issue Apr 25, 2019 · 1 comment
Open

Allow zero-length QUIC frames to be sent #67

tomdedecker opened this issue Apr 25, 2019 · 1 comment
Labels

Comments

@tomdedecker
Copy link
Collaborator

At the moment, doing QuicStream.end() without buffering new data will result in the stream end not being sent to the other endpoint. This is a result of zero-length QUIC frames not being supported by QUICker yet.

@rmarx
Copy link
Owner

rmarx commented Apr 25, 2019

A more quic-centric explanation:

Currently, quicker only sends new STREAM frames if there is actual data for that stream. Ending a stream is just sending a STREAM frame with the appropriate frame type (FIN, length and offset are specified in the frame type, rather than a specific flag or something). Due to how our flow control now creates new frames from streams, this is an edge case we don't deal with yet.

Expected behaviour:
stream.end() generates a 0-length STREAM frame with FIN set, ending that stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants