Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there still a need to install hadley/testthat#594 or can testthat 1.0.2 be used. #20

Open
FvD opened this issue Sep 2, 2017 · 1 comment

Comments

@FvD
Copy link

FvD commented Sep 2, 2017

Is this still true:

testthat (must use devtools::install_github("hadley/testthat#594") for now)

It seems to run fine with the current version of CRAN testthat 1.0.2, but I have not tried all expect_* so perhaps I'm setting myself up to run into trouble soon.

Do you know of any limitations when using testthat 1.0.2 works with testrmd? Or can you share the previously known issues so that I can check if they still cause trouble?

@rmflight
Copy link
Owner

rmflight commented Sep 2, 2017

Well, that is good to hear.

I don't see r-lib/testthat#594 or r-lib/testthat#597 having been merged though, so I can't vouch for testthat. I do know that an issue was that if you tried to use testthat as the compliance engine in testrmd it would not catch things properly.

Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants