Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL 1.9 support #30

Open
rmosolgo opened this issue Oct 25, 2018 · 1 comment
Open

GraphQL 1.9 support #30

rmosolgo opened this issue Oct 25, 2018 · 1 comment

Comments

@rmosolgo
Copy link
Owner

GraphQL 1.9 has immutable AST nodes, which breaks this library, because this library's basic flow is to instantiate a node, then assign values to it during the visit.

I think the library could be refactored to initialize a Hash, accumulate values in the hash, then instantiate a node when all the attributes are present.

@relwell
Copy link

relwell commented Oct 29, 2019

@rmosolgo I think the README for this library merits a deprecation warning. I spent a couple hours this morning digging into this exact problem. If your recommendations in rmosolgo/graphql-ruby#2398 were mentioned there, I think it'd save a lot of time for those interested in implementing this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants