Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve_type vs is_type_of #1267

Closed
axos88 opened this issue Feb 7, 2018 · 1 comment
Closed

resolve_type vs is_type_of #1267

axos88 opened this issue Feb 7, 2018 · 1 comment

Comments

@axos88
Copy link

axos88 commented Feb 7, 2018

Possibly related: #1193

Is there a way to define the typeresolve within the concrete types? Apollo uses isTypeOf for this: https://launchpad.graphql.com/zrz504kp37

This would enable better separation of concerns between the interface and the implementations, as the interface need not to know about every concrete type, and how do differentiate them.

@rmosolgo
Copy link
Owner

Thanks for the suggestion, but I don't have any plans to change this right now. The advantage isn't clear to me (at least, not in a way that is worth the complexity of a refactor). Unfortunately Launchpad seems to have stopped its service :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants