Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.12.0 #3056

Closed
33 tasks done
rmosolgo opened this issue Aug 1, 2020 · 4 comments
Closed
33 tasks done

Release 1.12.0 #3056

rmosolgo opened this issue Aug 1, 2020 · 4 comments
Milestone

Comments

@rmosolgo
Copy link
Owner

rmosolgo commented Aug 1, 2020

This is a checklist and tracking issue for the next release of GraphQL-Ruby.

@newx
Copy link
Contributor

newx commented Dec 3, 2020

@rmosolgo if you could provide more info about the remaining TODO items, I could try to help working on some of them :)

@rmosolgo
Copy link
Owner Author

👋 @newx ! A couple of the big features already have open PRs. I just need to wrap those up.

Besides that, all the parts of graphql-ruby listed above need to have deprecation warnings because they'll be removed in GraphQL-Ruby 2.0. I'm not really sure what needs to be done there. We need something that will warn reliably without spamming the logs with warnings.

I think warn "..." would be sufficient, as long as each warning includes:

  • What thing is deprecated
  • Where the deprecated thing is being used (some part of caller, so that the reader knows what lines of their own code to change)
  • What thing to use instead of the deprecated thing (including a usage example and/or link to documentation)

The goal is for the deprecation warning to be so good that someone who sees it can make the required change without opening an issue on github (or maybe even without searching the docs!).

If you're interested in adding some of those, feel free to pick a few items off the list and open a PR. That way we can make sure the messaging aligns with my goals above before you add a lot of them.

There will also be some work in updating GraphQL-Ruby's own code and tests to make sure those deprecated things are not used. In my opinion, that can be done after adding the warnings. (Besides, GraphQL-Ruby's own deprecated usage can help us make sure the warnings work 😆 !)

@newx
Copy link
Contributor

newx commented Dec 10, 2020

@rmosolgo Cool. I will take a look at these and get back to you soon. Thank you

@rmosolgo
Copy link
Owner Author

🚢 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants