Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade better-sqlite3 version in package.json #150

Closed
JamesBarwell opened this issue Sep 6, 2024 · 0 comments · Fixed by #151
Closed

Upgrade better-sqlite3 version in package.json #150

JamesBarwell opened this issue Sep 6, 2024 · 0 comments · Fixed by #151

Comments

@JamesBarwell
Copy link

Hi, thanks for this fantastic project.

Would you consider upgrading the better-sqlite3 peer dependency to the latest please? It is currently set to ^9.4.3. The latest version is 11.2.1.

I am currently installing both using npm install --force and haven't encountered any issues with the latest versions of both modules.

By the way, I noticed that Knex only sets peerDependenciesMeta and doesn't specify peerDependencies in its package.json. I'm not very expert on these but I wonder if that approach would work to avoid having to manage versions?

See: https://www.npmjs.com/package/better-sqlite3

Example install log:

$ npm install better-sqlite3

added 38 packages, and audited 39 packages in 3s

9 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

$ npm install @rmp135/sql-ts
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @rmp135/sql-ts@2.1.0
npm error Found: better-sqlite3@11.2.1
npm error node_modules/better-sqlite3
npm error   better-sqlite3@"^11.2.1" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional better-sqlite3@"^9.4.3" from @rmp135/sql-ts@2.1.0
npm error node_modules/@rmp135/sql-ts
npm error   @rmp135/sql-ts@"*" from the root project
npm error
npm error Conflicting peer dependency: better-sqlite3@9.6.0
npm error node_modules/better-sqlite3
npm error   peerOptional better-sqlite3@"^9.4.3" from @rmp135/sql-ts@2.1.0
npm error   node_modules/@rmp135/sql-ts
npm error     @rmp135/sql-ts@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/james/.npm/_logs/2024-09-06T13_31_18_747Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/james/.npm/_logs/2024-09-06T13_31_18_747Z-debug-0.log

$ cat package.json 
{
  "name": "test",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "description": "",
  "dependencies": {
    "better-sqlite3": "^11.2.1"
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant