Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pallet owned account_id #36

Closed
ilionic opened this issue Dec 28, 2021 · 2 comments
Closed

Consider pallet owned account_id #36

ilionic opened this issue Dec 28, 2021 · 2 comments
Assignees
Milestone

Comments

@ilionic
Copy link
Contributor

ilionic commented Dec 28, 2021

by h4x3rotab:

let (collection_id, nft_id) = Self::nft_mint(
    sender.clone().unwrap_or_default(),
    owner,
    collection_id,
    recipient,
    royalty,
    metadata,
)?;

When sender == None? If it means the origin is some admin (ProtocolOrigin), I suggest to use pallet's account id instead of the default account id (0x0), which is going to be deprecated soon due to some security concern.

Example of a pallet owned account_id:
https://github.com/paritytech/substrate/blob/d18705ee7b5b654d3947558fea6dbd0701ac3ecc/frame/society/src/lib.rs#L1733-L1735

@ilionic ilionic added this to the rmrk-core milestone Dec 28, 2021
@ilionic ilionic assigned ilionic and unassigned ilionic Dec 29, 2021
@ilionic ilionic self-assigned this Dec 29, 2021
@ilionic
Copy link
Contributor Author

ilionic commented Dec 29, 2021

@h4x3rotab would you agree with simplified ensure all signed calls approach in #40 PR?

@h4x3rotab
Copy link
Contributor

Looks perfect!

@ilionic ilionic closed this as completed Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants