-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider pallet owned account_id #36
Milestone
Comments
@h4x3rotab would you agree with simplified ensure all signed calls approach in #40 PR? |
Looks perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
by h4x3rotab:
When
sender == None
? If it means the origin is some admin (ProtocolOrigin), I suggest to use pallet's account id instead of the default account id (0x0), which is going to be deprecated soon due to some security concern.Example of a pallet owned account_id:
https://github.com/paritytech/substrate/blob/d18705ee7b5b654d3947558fea6dbd0701ac3ecc/frame/society/src/lib.rs#L1733-L1735
The text was updated successfully, but these errors were encountered: