Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Aggregating properties for clustered features #693

Closed
ivari opened this issue Feb 28, 2020 · 5 comments
Closed

Feature Request: Aggregating properties for clustered features #693

ivari opened this issue Feb 28, 2020 · 5 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@ivari
Copy link
Contributor

ivari commented Feb 28, 2020

Late last year, Mapbox implemented clusterProperties attribute for ShapeSource, which enables declaring custom aggregated properties for clustered features on the map.

Android: mapbox/mapbox-gl-native#15425
iOS: mapbox/mapbox-gl-native#15515

I would very much like to see this implemented, as we have a use case in our app where we want to open a new view on cluster tap, which shows information for all features clustered under the icon. Additionally, we want to show information on the icon which is more complex than simple {point_count}.

I have started implementing it myself, and got it working on Android – but due to the outstanding use_frameworks! issue on iOS (mapbox/mapbox-gl-native-ios#154), I haven't been able to fully test this.

If anyone wants to take over the branch from https://github.com/ivari/maps/tree/implement-clustering-properties, you're welcome to do so – otherwise I'll come back to this at some future point and try to get a PR up.

@mfazekas mfazekas added the enhancement New feature or request label Feb 28, 2020
@mfazekas
Copy link
Contributor

mfazekas commented Apr 3, 2020

@ivari thanks it looks great, we'd need an example. BTW for use_frameworks! we now have a workaround: https://github.com/react-native-mapbox-gl/maps/pull/714

@stale
Copy link

stale bot commented Jun 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 2, 2020
@stale stale bot closed this as completed Jun 9, 2020
@naomigrace
Copy link

Would love to see this implemented.

@btuck044
Copy link

Same here

@ivari
Copy link
Contributor Author

ivari commented Feb 17, 2022

Please see https://github.com/react-native-mapbox-gl/maps/pull/1745 for implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants