Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add windows runner with enabled address sanitizer. #2147

Closed
ni4 opened this issue Nov 15, 2023 · 5 comments · Fixed by #2151
Closed

CI: Add windows runner with enabled address sanitizer. #2147

ni4 opened this issue Nov 15, 2023 · 5 comments · Fixed by #2151
Assignees

Comments

@ni4
Copy link
Contributor

ni4 commented Nov 15, 2023

Description

Since Visual Studio 2019 version 16.9 it supports address sanitizer, as described here: https://learn.microsoft.com/en-us/cpp/sanitizers/asan?view=msvc-170
Currently Github runners use 16.11, so it would be good to add Windows runs with address sanitizers enabled.

@ni4
Copy link
Contributor Author

ni4 commented Nov 15, 2023

@maxirmx Would you have time to look into it? I'm trying to build quick-n-dirty debug PoC here #2143, but that is not something which should go to the main.

@maxirmx
Copy link
Member

maxirmx commented Nov 15, 2023

@ni4,
I will look at it.

@maxirmx maxirmx self-assigned this Nov 15, 2023
@ni4
Copy link
Contributor Author

ni4 commented Nov 15, 2023

Thanks!

@ni4
Copy link
Contributor Author

ni4 commented Nov 16, 2023

@maxirmx Managed to build and run with sanitizers, you may find these lines useful:

if (ENABLE_SANITIZERS)
  add_compile_options(-fsanitize=address /Zi /MT)
  add_link_options(/DEBUG)
endif()

@maxirmx
Copy link
Member

maxirmx commented Nov 16, 2023

@ni4 thank you
I want to do some extra things. As I wrote elsewhere right now python scripts can run in Unix environment only (== MSys on Windows) even we are doing native MSVC build
Practically it means that it is not possible to use debugger and it is very har to run tests locally.
I would like to fix it to support future bug fix

@maxirmx maxirmx linked a pull request Nov 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants