Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡 FEATURE REQUEST]: Temporal: support TLS connection #1237

Closed
seregazhuk opened this issue Jul 28, 2022 · 0 comments · Fixed by temporalio/roadrunner-temporal#250
Closed
Assignees
Labels
C-feature-request Category: feature requested, but need to be discussed
Milestone

Comments

@seregazhuk
Copy link

seregazhuk commented Jul 28, 2022

Support TLS connection

Need to support TLS connection. Our case is Temporal server, that works under TLS. It can be reached by grpcurl:

grpcurl temporal-dev:7233 list
grpc.health.v1.Health
grpc.reflection.v1alpha.ServerReflection
temporal.api.operatorservice.v1.OperatorService
temporal.api.workflowservice.v1.WorkflowService
temporal.server.api.adminservice.v1.AdminService

but at the same time while connecting to it with RR it throws error:

handle_serve_command: Serve error:
        endure_start:
        endure_serve_internal: Function call error:
        endure_call_serve_fn: got initial serve error from the Vertex roadrunner_temporal.Plugin, stopping execution, error: temporal_plugin_serve: failed reaching server: last connection error: connection closed before server preface received

Temporal part of rr.yaml is the following:

temporal:
  address: temporal-dev:7233
@seregazhuk seregazhuk added the C-feature-request Category: feature requested, but need to be discussed label Jul 28, 2022
@seregazhuk seregazhuk changed the title [💡 FEATURE REQUEST]: [💡 FEATURE REQUEST]: Support TLS connection Jul 28, 2022
@rustatian rustatian changed the title [💡 FEATURE REQUEST]: Support TLS connection [💡 FEATURE REQUEST]: Temporal: support TLS connection Jul 28, 2022
@rustatian rustatian added this to General Aug 3, 2022
@rustatian rustatian added this to the v2.11.0 milestone Aug 3, 2022
@rustatian rustatian moved this to Backlog in General Aug 3, 2022
@rustatian rustatian moved this from Backlog to Todo in General Aug 3, 2022
@rustatian rustatian moved this from Todo to In Progress in General Aug 3, 2022
Repository owner moved this from In Progress to Unreleased in General Aug 3, 2022
@rustatian rustatian moved this from Unreleased to Done in General Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: feature requested, but need to be discussed
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants