Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡 FEATURE REQUEST]: Add the ability to configure the user and group for on_init and after_init phases #1585

Closed
Kaspiman opened this issue May 29, 2023 · 3 comments · Fixed by roadrunner-server/server#68
Assignees
Labels
C-feature-request Category: feature requested, but need to be discussed

Comments

@Kaspiman
Copy link

Plugin

Server

I have an idea!

Feature is a very similar to this #1570

on_init contained in server section but doesn't inherit user/group parameters. I want to specify these parameters explicitly.

server:
    command: "php public/index.php"
    user: www-data
    group: www-data
    on_init:
        command: "bin/console command:whoami" # echo whoami = root
        # user: www-data
        # group: www-data

This is not a duplicate of this issue. This is not intended to break backwards compatibility.

@Kaspiman Kaspiman added the C-feature-request Category: feature requested, but need to be discussed label May 29, 2023
@rustatian
Copy link
Member

Hey @Kaspiman 👋🏻
All commands user and group are configured via existing server plugin options. I don't think, that we should duplicate them.

@github-project-automation github-project-automation bot moved this to Backlog in General May 29, 2023
@rustatian rustatian moved this from Backlog to Done in General May 29, 2023
@Kaspiman
Copy link
Author

Kaspiman commented May 29, 2023

Unfortunately, user and group settings are not inherited from the server section. on_init and after_init commands runs as root, not as server configured.

@rustatian
Copy link
Member

You're right, but your FR is about updating the configuration to achieve this. You can edit it if you want.

@rustatian rustatian moved this to 👀 In review in Jira 😄 Jan 10, 2024
@rustatian rustatian moved this from 👀 In review to ✅ Done in Jira 😄 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: feature requested, but need to be discussed
Projects
Status: ✅ Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants