Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[💡 FEATURE REQUEST]: Notify service manager about start-up completion and other service status changes #1654

Closed
Kaspiman opened this issue Jul 25, 2023 · 2 comments · Fixed by #1671
Closed

[💡 FEATURE REQUEST]: Notify service manager about start-up completion and other service status changes #1654

Kaspiman opened this issue Jul 25, 2023 · 2 comments · Fixed by #1671
Assignees
@rustatian
Labels
C-feature-request Category: feature requested, but need to be discussed
Milestone
v2023.3.0

Comments

@Kaspiman
Copy link
Sponsor

Kaspiman commented Jul 25, 2023 •
edited
Loading

Plugin

None

I have an idea!

i'm using Roadrunner + Systemd and having a little restart problems. Command systemctl restart roadrunner with default unit does not guarantee server readiness.

Comes to mind to use a script and check port availability with wait-for-it.sh or something else.

Maybe we can add come signals like sd_notify? People already has library for that.

EDIT:
Some docs:

  1. https://www.freedesktop.org/software/systemd/man/systemd.service.html#NotifyAccess=
  2. https://www.freedesktop.org/software/systemd/man/sd_notify.html#
@Kaspiman Kaspiman added the C-feature-request Category: feature requested, but need to be discussed label Jul 25, 2023
@rustatian
Copy link
Member

Hey @Kaspiman 👋🏻
Yeah, nice idea. I'll look into that, thanks 👍🏻

@rustatian rustatian added this to the v2023.3.0 milestone Jul 28, 2023
@rustatian rustatian mentioned this issue Jul 28, 2023
Closed
This was referenced Aug 6, 2023
Merged
Closed
@rustatian
Copy link
Member

To test the feature, feel free to download build artifacts here: https://github.com/roadrunner-server/roadrunner/actions/runs/5867205849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
C-feature-request Category: feature requested, but need to be discussed
Projects
No open projects
General
Status: Unreleased
Milestone
v2023.3.0
Development

Successfully merging a pull request may close this issue.

feature: sd_notify support roadrunner-server/roadrunner
2 participants
@rustatian @Kaspiman