Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG]: debug and max_jobs does not work #1670

Closed
1 task done
wapmorgan opened this issue Aug 6, 2023 · 2 comments
Closed
1 task done

[🐛 BUG]: debug and max_jobs does not work #1670

wapmorgan opened this issue Aug 6, 2023 · 2 comments
Assignees
Labels
B-bug Bug: bug, exception F-need-verification

Comments

@wapmorgan
Copy link

wapmorgan commented Aug 6, 2023

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

A bug happened!

http.pool.debug and http.pool.max_jobs are buggy.

Version (rr --version)

2023.1.0 / 2023.1.5 / 2023.2.1

How to reproduce the issue?

Dockerfile
FROM ghcr.io/roadrunner-server/roadrunner:2023.1.0 AS roadrunner
.rr.yaml

version: '3'
server:
  command: "php web/api.php"

http:
  address: 0.0.0.0:8080
  pool:
    debug: ${DEBUG}
    num_workers: ${NUM_WORKERS}
    max_jobs: ${NUM_REQUESTS_BEFORE_RESET}

rpc:
  listen: tcp://127.0.0.1:6001

server command

  • does not matter.

Relevant log output

when debug=true

[INFO] RoadRunner server started; version: 2023.1.0, buildtime: 2023-04-13T16:47:17+0000
2023-08-06T18:07:37+0000        DEBUG   http            http server was started {"address": "0.0.0.0:8080"}
2023-08-06T18:07:47+0000        DEBUG   server          worker is allocated     {"pid": 19, "internal_event_name": "EventWorkerConstruct"}
2023-08-06T18:07:47+0000        DEBUG   server          sending stop request to the worker      {"pid": 19}
2023-08-06T18:07:57+0000        WARN    server          worker doesn't respond on stop command, killing process {"PID": 19}
2023-08-06T18:07:57+0000        DEBUG   server          debug mode: worker stopped      {"reason": "worker error", "pid": 19, "internal_event_name": "EventWorkerError", "error": "process_stop: Network"}
2023-08-06T18:07:57+0000        ERROR   http            execute {"start": "2023-08-06T18:07:47+0000", "elapsed": "10.015244843s", "error": "process_stop: Network"}
2023-08-06T18:07:57+0000        INFO    http            http log        {"status": 500, "method": "GET", "URI": "/", "remote_address": "172.17.0.1:45720", "read_bytes": 0, "write_bytes": 0, "start": "2023-08-06T18:07:47+0000", "elapsed": "10.015352563s"}

when debug=false and max_jobs=1

2023-08-06T18:15:48+0000        DEBUG   server          sending stop request to the worker      {"pid": 32}

2023-08-06T18:15:58+0000        WARN    server          worker doesn't respond on stop command, killing process {"PID": 32}
2023-08-06T18:15:58+0000        DEBUG   server          worker release  {"error": "process_stop: Network"}
2023-08-06T18:15:58+0000        INFO    http            http log        {"status": 200, "method": "GET", "URI": "/", "remote_address": "172.17.0.1:57640", "read_bytes": 0, "write_bytes": 17, "start": "2023-08-06T18:15:48+0000", "elapsed": "10.002420988s"}
2023-08-06T18:15:58+0000        DEBUG   server          worker stopped  {"internal_event_name": "EventWorkerWaitExit", "error": "signal: killed\nprocess_wait: signal: killed"}
2023-08-06T18:15:58+0000        DEBUG   server          worker is allocated     {"pid": 33, "internal_event_name": "EventWorkerConstruct"}
@rustatian
Copy link
Member

Hey @wapmorgan 👋🏻
I double-checked this case on the latest v2023.2.1 release. Looks like the problem is somewhere on your end. Double check your worker, docker configuration. Looks like the process can't be allocated on the second run for some reason. The issue is not locked.

image

@rustatian rustatian added this to General Aug 6, 2023
@github-project-automation github-project-automation bot moved this to Backlog in General Aug 6, 2023
@rustatian rustatian moved this from Backlog to Done in General Aug 6, 2023
@wapmorgan
Copy link
Author

Problem is in sample #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception F-need-verification
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants