Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[💡 FEATURE REQUEST]: OTLP support for gRPC #1782

Closed
rauanmayemir opened this issue Nov 16, 2023 · 3 comments · Fixed by roadrunner-server/grpc#131
Closed

[💡 FEATURE REQUEST]: OTLP support for gRPC #1782

rauanmayemir opened this issue Nov 16, 2023 · 3 comments · Fixed by roadrunner-server/grpc#131
Assignees
@rustatian
Labels
C-feature-accepted Category: Feature discussed and accepted P-GRPC Plugins: GRPC R-stable Release: Nominated for backporting to the RR in the stable channel.
Milestone
v2023.3.8

Comments

@rauanmayemir
Copy link

Plugin

GRPC

I have an idea!

Trace collection for gRPC is currently not supported.

While the spiral side of the trace could be done manually, there will still be a lag on the RR side.
Would be nice to have it for RR, too.
@rauanmayemir rauanmayemir added the C-feature-request Category: feature requested, but need to be discussed label Nov 16, 2023
@rustatian rustatian added this to the v2024.1.0 milestone Nov 16, 2023
@rustatian rustatian moved this to 📋 Backlog in Jira 😄 Nov 16, 2023
@rustatian
Copy link
Member

Hey @rauanmayemir 👋
Traces for the gRPC can be configured via env variables for the RR at the moment. We have an updated stats handler attached.
Better support via otel plugin will be added in 2024.1.0.

@rustatian rustatian added C-feature-accepted Category: Feature discussed and accepted P-GRPC Plugins: GRPC R-stable Release: Nominated for backporting to the RR in the stable channel. and removed C-feature-request Category: feature requested, but need to be discussed labels Nov 16, 2023
@rauanmayemir
Copy link
Author

@rustatian Which env vars should I use? I'd like to add at least some basic otel support.

@rustatian
Copy link
Member

rustatian commented Nov 17, 2023 •
edited
Loading

@rauanmayemir Here you are: link
I didn't test them, tho. You may try to play with them, but the real support for the OTEL will be added in v2024.1.0.

@rustatian rustatian moved this from 📋 Backlog to 🏗 In progress in Jira 😄 Dec 3, 2023
@rustatian rustatian mentioned this issue Dec 3, 2023
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jira 😄 Dec 3, 2023
@rustatian rustatian modified the milestones: v2024.1.0, v2023.3.8 Dec 3, 2023
@krehel krehel mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
C-feature-accepted Category: Feature discussed and accepted P-GRPC Plugins: GRPC R-stable Release: Nominated for backporting to the RR in the stable channel.
Projects
Jira 😄
Status: ✅ Done
Milestone
v2023.3.8
Development

Successfully merging a pull request may close this issue.

feature: experimental tracing support roadrunner-server/grpc
2 participants
@rauanmayemir @rustatian