-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider hotkey libraries other than react-hotkeys #68
Comments
I've used mousetrap in the past, with no issues. Not very complex usage though (no keychords etc) but actively used as core feature of my app for several years. |
react-hotkeys v1.x uses mousetrap, and had reached a very stable state before v2 was published. |
Another vote for mousetrap here. Though, it does have some smelly bits. For example, when developing my todoist-shortcuts browser extension, I noticed that it has an arbitrary time limit of 1 second for completing a key sequence, so my fork removes that. |
@mgsloan the details of the underlying library are mostly abstracted away. So I don't think the dev experience would differ that much between the options. |
roam-toolkit currently uses https://github.com/greena13/react-hotkeys to listen to keys.
It works well for the most part, but various bugs made vim style bindings harder to implement:
Also, react-hotkeys is no longer actively maintained.
This deliverable here would be evaluating other options, and seeing how much there is to be gained by switching.
Other options:
https://github.com/ccampbell/mousetrap
https://github.com/jaywcjlove/hotkeys
Help maintain react-hotkeys
Roll our own hotkey library
The text was updated successfully, but these errors were encountered: