Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show line numbers for pending step #14

Open
j-clark opened this issue Dec 2, 2013 · 3 comments
Open

Show line numbers for pending step #14

j-clark opened this issue Dec 2, 2013 · 3 comments

Comments

@j-clark
Copy link

j-clark commented Dec 2, 2013

When a step is defined, but not implemented, the message should show the line number of the step. Currently only the line number of the scenario is shown.

@robb1e
Copy link
Owner

robb1e commented Dec 4, 2013

The printing of the scenario number is from RSpec I assume. When you mean not implemented, do you mean the method doesn't exist so you're getting the pending message? Is it the line number of the Given/When/Then call you'd like printed?

@j-clark
Copy link
Author

j-clark commented Dec 4, 2013

Yeah, exactly. Here's an example:

± ak+jc |staging |  rspec spec/features/my_spec.rb:50
Run options: include {:locations=>{"./spec/features/my_spec.rb"=>[50]}}
 1/1 |================================================= 100 =================================================>| Time: 00:00:00

Pending:
  Someone does something
    # i_facilitate_doing_something
    # ./spec/features/my_spec.rb:50

Finished in 0.39671 seconds
1 example, 0 failures, 1 pending

It would be cool if the message was something along the lines of

Pending:
  Someone does something
    # ./spec/features/my_spec.rb:51 in `i_facilitate_doing_something'
    # ./spec/features/my_spec.rb:50

Sort of like a normal stack trace. Or something along those lines.

Thoughts? Not sure how hard this would be to implement. I might try to submit a pull request if you like the idea

@robb1e
Copy link
Owner

robb1e commented Dec 4, 2013

Have a crack at the pull request, would be happy to accept if you can get working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants