Lacking support for React 18

[TheIceCreamBear]

Is your feature request related to a problem? Please describe.
This is incompatible with React 18 via peer dependency. If you attempt to install this with React 18 installed, npm will give you an error

Describe the solution you'd like
I would like to see the peer dependencies updated to allow for this to be installed into a react 18 project

Describe alternatives you've considered
I have considered forking this repo and fixing it or using an existing fork, but I would prefer for the main repository to have this fix.

Additional context
Example of error:

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: web@0.1.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0" from xterm-for-react@1.0.4
npm ERR! node_modules/xterm-for-react
npm ERR!   xterm-for-react@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

[jaxtonw]

@robert-harbison Has there been any updates on this? I'd love to integrate this into my current project, but need React 18 support. I'd much rather use the main repository than my own or someone else's fork.

If you're needing any help with the upgrades, I'd be happy to help!

[jaxtonw]

I'm currently working on a fork that updates this package to use the most up to date dependencies and support React 18. Once I verify this, I will be opening a PR. If anyone wants to contribute, feel free!

https://github.com/jaxtonw/xterm-for-react18/tree/react18

[jaxtonw]

I have opened a pull request, #24 which adds support for React 18! If this gets approved, it would be great if the package on NPM could be updated as well.

[AbanoubYounan]

Hi,
I think this https://socket.dev/npm/package/xterm-for-react-18 will solve your problem

[jaxtonw]

@AbanoubYounan I appreciate you trying to suggest a fix, however that package has no publicly available code and is namesquatting. At best that package is pointless, and at worst it may be malicious. As of my current (and quick) investigation, it does not actually appear to be malicious, but it is not advised that people use this package.

[bryandandan]

I have opened a pull request, #24 which adds support for React 18! If this gets approved, it would be great if the package on NPM could be updated as well.

Has the PR been approved yet? Fans are impatient to use xterm-for-react with React 18

[nsoubelet]

@jaxtonw thanks for your work!
Have you even received any answer from the owner of this package latelly? - If not, I see no point in keep waiting, and we should maybe start using your forked version if published in npm. Or at least I will do since this one seems to be abandoned since last year.
What do you think?

[jaxtonw]

@nsoubelet it is starting to get to that point. I'll ping @robert-harbison again to see if they will respond. If I don't hear back from them in the next few days, I'll start working on publishing my forked version on NPM, update some documentation, and clearly give @robert-harbison credit for creating the project.

I've also been thinking it may be worth migrating to a functional component. That will come after the forked version goes on NPM and is confirmed to work for others.

[nsoubelet]

Hello @jaxtonw, I guess you did not hear back from devs.
Any plans to publish your forked version on NPM during July?

[jaxtonw]

@nsoubelet apologies for not responding earlier. My focus has been on research, thesis, and an internship. I do plan to publish this package soon, unless @robert-harbison hops back on and merges in my work.

[JensvandeWiel]

Its been so long

[kylebonnici]

Any updates on this?
@jaxtonw did you release your fix to NPM I am very eager to try it?
@robert-harbison any plan to merge this to main and release?

[arcabezudo]

Hey @jaxtonw are there any updates? I am eager to use this module with React 18.

[mastersign]

Hi @arcaguax I am currently using this module with success so far:
https://gist.github.com/mastersign/90d0ab06f040092e4ca27a3b59820cb9

You may remove or alter the used XTermJS plugins. Be aware, that the fontfaceobserver package is required too.

[uaena001]

很抱歉没有早点回复。我的重点是研究、论文和实习。我确实计划很快发布这个包，除非跳回去并合并到我的工作中。

Hi,can you tell me when you finally released support fron react-18?According to the link you posted,the downloadable package is still the one that does not support react-18.Thank you!

[arcabezudo]

很抱歉没有早点回复。我的重点是研究、论文和实习。我确实计划很快发布这个包，除非跳回去并合并到我的工作中。

Hi,can you tell me when you finally released support fron react-18?According to the link you posted,the downloadable package is still the one that does not support react-18.Thank you!

@uaena001 There is a misunderstanding in the translation.
The updated package has not been released by @jaxtonw yet.

@mastersign I will give it a try thanks!