Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve round-trip #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jeremyrsellars
Copy link

@jeremyrsellars jeremyrsellars commented Nov 8, 2023

Fixes #2. Fixes #3.

  • Test more scenarios with generative tests via test.check.
  • Fixes diff and patch when maps have nil or false as keys.
  • Fixes support for sequences that change from one data structure to another.
  • Fixes support for sequences which become empty.
  • Add deps.edn for tools.deps git coordinates.
  • Update dependencies and build targets.
  • Proposes changing library to version 0.4.0.
  • Support replacing a record with another record.

fix(removals): Fix removing all items from set

fix(patch): fix removing all elements

Fix moving toward empty collections
Don't throw when diffing/patching recursive structures containing records.  Treats records as atomic (does not subdivide records).
Fix robinheghan#2
@jeremyrsellars jeremyrsellars marked this pull request as ready for review November 8, 2023 15:29
@jeremyrsellars
Copy link
Author

My company has stored many months of diffs (version 0.3.3). I ran millions of them through to make sure the new 0.4.0 patch function could process the 0.3.3 diffs without exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot apply patch replacing a vector with a string Can't empty a Record
1 participant