Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player String Processing #36

Open
robinje opened this issue Feb 3, 2024 · 5 comments
Open

Player String Processing #36

robinje opened this issue Feb 3, 2024 · 5 comments
Labels
go Pull requests that update Go code good first issue Good for newcomers

Comments

@robinje
Copy link
Owner

robinje commented Feb 3, 2024

Currently string input is simply lowered for processing. This approach should be refined to allow the players to send messages in any desired case.

@robinje robinje added good first issue Good for newcomers go Pull requests that update Go code labels Feb 3, 2024
@efeertugrul
Copy link

would you describe the issue more clear? @robinje

@robinje
Copy link
Owner Author

robinje commented Feb 3, 2024

What I put together for the first part was just to send all of the user input to lower case, which isn't great for players expressing themselves with the say command.

My general thought is that the lower case should be applied at the testing for verbs. If say is the first verb everything after that should be left as is and sent back through the system in the provided case.

@efeertugrul
Copy link

I was curious that if i could participate to this repository but I had problems running it on my local. If you provide the steps to get the software up and running in the README.md file, I may contribute. Cause it sounds fun.

@robinje
Copy link
Owner Author

robinje commented Feb 5, 2024

@efeertugrul I have added the deployment instructions to the README with PR #52. I also created Issue #51 for a non-AWS deployment.

@robinje
Copy link
Owner Author

robinje commented Feb 12, 2024

PRs #73 and #76 have started to address this item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants