Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on failure #439

Closed
mudler opened this issue May 28, 2022 · 4 comments · Fixed by #441
Closed

Retry on failure #439

mudler opened this issue May 28, 2022 · 4 comments · Fixed by #441

Comments

@mudler
Copy link

mudler commented May 28, 2022

Thanks for building this action! that was exactly what I needed for some of my projects :)

Is your feature request related to a problem? Please describe.
When running this action on macOS runners, I hit #347 quite a lot of times. Restarting the job a couple of times eventually makes it successfull

Describe the solution you'd like
A way for the action to retry on failure, for example, by specifying a max number of retry attempts and a delay time in between

Describe alternatives you've considered

Additional context
At https://github.com/c3os-io/c3os/ I'm planning to use this action to run upgrade tests from latest releases - but currently this is almost not doable at all for the problem mentioned above

@robinraju
Copy link
Owner

@mudler This is caused by GitHub rate limiting API calls from macOS runner.
This action uses the GH API under the hood.

Can you try providing the default GitHub token as follows

- uses: robinraju/release-downloader@v1.3
  with:
    latest: true
    fileName: "foo.zip"
    token: ${{ secrets.GITHUB_TOKEN }}

You don't need to generate a new token. This one is available on the actions runtime. See: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret

If this works for you on macOS runner, I'll make this default to this action.

@robinraju
Copy link
Owner

Update:
A possible fix is merged in #441

@mudler can you try using the latest commit from main as follows

- uses: robinraju/release-downloader@36fe95787d3f42ee0e69626e12775d15c7c14d38
  with:
    latest: true
    fileName: "foo.zip"

@mudler
Copy link
Author

mudler commented May 29, 2022

@robinraju thanks! I'll give it a try and keep you posted

@robinraju
Copy link
Owner

Closing this issue, as the macOS builds are stable for some time on this repo. Please use the latest version of this action (it contains the fix for this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants