Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overflowStyle not applied in IE 11 #157

Closed
screendriver opened this issue Mar 23, 2018 · 2 comments
Closed

overflowStyle not applied in IE 11 #157

screendriver opened this issue Mar 23, 2018 · 2 comments

Comments

@screendriver
Copy link

screendriver commented Mar 23, 2018

I'm using glamorous and want to use overflowStyle in my code. I already created an issue there paypal/glamorous#400 and was redirected here

  • glamorous version: 4.12.1
  • glamor version: 2.20.40
  • react version: 16.2.0
  • typescript version: 2.7.2

Relevant code.

const MyComponent = glamorous.div({
  overflowStyle: 'none',
  '-ms-overflow-style': 'none',
});

What you did:

I want to apply the styles written above. But unfortunately overflowStyle will not be applied in IE 11. Instead I have to write manually '-ms-overflow-style': 'none' (as you can see in the last line). Shouldn't browser prefixes be done automatically?

What happened:

When I just write overflowStyle: 'none' without '-ms-overflow-style': 'none' then nothing will be applied in IE 11. In Chrome conversely I can see a overflow-style: 'none' (with a warning that this property is not supported, but that's ok here)

@robinweser
Copy link
Owner

Hey there, I just checked the documentation:
https://developer.mozilla.org/en-US/docs/Web/CSS/-ms-overflow-style
Looks like that's an unofficial property introduced only by Microsoft. This prefixer does not prefix unofficial properties, so you would have to provide the prefixed version yourself

Note: Looks like overflowStyle is not even part of the CSS spec?
(Source: https://drafts.csswg.org/css-overflow-3/#propdef-overflow)

You should try

const MyComponent = glamorous.div({
  msOverflowStyle: 'none'
})

@screendriver
Copy link
Author

Thank for the information 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants