Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flex shorthand syntax is not expanded for IE10 #165

Closed
calinoracation opened this issue Oct 10, 2018 · 2 comments · Fixed by #166
Closed

flex shorthand syntax is not expanded for IE10 #165

calinoracation opened this issue Oct 10, 2018 · 2 comments · Fixed by #166

Comments

@calinoracation
Copy link

calinoracation commented Oct 10, 2018

We've been working on supporting IE10 with aphrodite which uses this library. We have added a global reset for -ms-flex: 0 1 auto; for all elements in our normalization, but in order to get flex working reasonably we needed to change all of our shorthand usages of flex: 1 style syntax to have all of the values for flex-grow | flex-shrink | flex-basis as specified at https://developer.mozilla.org/en-US/docs/Web/CSS/flex.

So for example flex: 1 would be translated to flex: 1 1 0% and flex: 0 would be translated to flex: 0 1 0%.

I would like to create a PR here to add support for it but wanted to make sure to open an issue first to ensure it's a reasonable thing to add support for.

For others needing IE10 support to get the default flex value we tried to use something like this:

*,
*:before,
*:after {
  -ms-flex: 0 1 auto;
}
@robinweser
Copy link
Owner

Hmm, in general, this package is not responsible for fixing browser differences but rather to just add prefixes where needed, but I can see it might help and is specific to IE10 which the default package doesn't even support anyways, so we might add that to the flexboxIE plugin if you want to.

@calinoracation
Copy link
Author

Fantastic, thanks for the response, I'll try to add it to that flexboxIE plugin and get a PR up soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants