Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update column with , in definition (SQLite) #1006

Merged
merged 4 commits into from
Jan 21, 2017

Conversation

fquffio
Copy link
Contributor

@fquffio fquffio commented Jan 4, 2017

When using SQLite adapter, if a column is created and contains one or more , in its definition (e.g. in its default value, or comment), that column cannot be updated anymore, as the regex that changes the corresponding SQL fragment fails to properly detect the end.

This PR should solve the problem, along with adding a regression test.

@fquffio
Copy link
Contributor Author

fquffio commented Jan 20, 2017

Hey @robmorgan, sorry to bother.

Have you had the time to take a look at this? Is there any additional information that I should provide in order for this bugfix to be examined?
I hate to stress out people, but this bug is something that's actually breaking things up for us, and despite using branch aliases in Composer does indeed work, we'd like to see this just as a temporary solution. 🙃

Thanks aforehand for your attention!

@robmorgan robmorgan changed the base branch from 0.6.x-dev to master January 21, 2017 12:39
@robmorgan robmorgan merged commit 622343f into cakephp:master Jan 21, 2017
@robmorgan
Copy link
Member

@fquffio thanks for your contribution, sorry about the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants