Rollbacks by start time #1045
Merged
Rollbacks by start time #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 27, 2017 10:50
The old testRollbacksByDate test was renamed to testRollbackToDateTime and turned into a unit test, ensuring the rollback method is called with the right version. A new testRollback was added which ensures the correct output of the rollback operation (as was being done in the old testRollbacksByDate test). More test cases were added.
* A new version_order configuration option was added. * A new Config.getVersionOrder() and Config.isVersionOrderCreationTime() were added. * The getVersionLog() method now returns the versions indexed by version creation time but already in the proper order, according to the configuration version order. * The Manage's "rollback" and "rollbackToDateTime" methods were merged into one (simply named "rollback"). * The new Manager.rollback method was adapted so that it serves any combination of start/creation time ordering and target version/date. * The Rollback command now "fills" in missing parts of target dates. * Tests improved: now using test input/output from setUp. * Tests improved: the expectations for the underlying Manager calls now include the expected arguments.
* It now highlights the column the migrations are being ordered by. * Down migrations are now showing up in the right place.
Code that uses the version order value now also has a default clause to raise an exception in case of invalid values.
ghost
mentioned this pull request
|
@daniel-gomes-sociomantic Thank you for that. Can you look at PHPStan's output at https://travis-ci.org/robmorgan/phinx/jobs/205745493#L348 and fix accordingly. https://github.com/phpstan/phpstan is a static analysis tool which helps identify potential problems or inconsistent usages. VERY useful!!! |
|
there ya go |
|
Finally. A massive thank you for sticking with this/us/me on this. |
|
No problem! Which release is this gonna be in, then? |
|
https://github.com/robmorgan/phinx/releases/tag/v0.8.0 Released last night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Configuration option named
version_orderwas added. Its possible values are:creation(the default): causes the Rollback and Status commands to order the executed migrations by their Creation Times (aka Migration IDs or Names).execution: causes the Rollback and Status commands to order the executed migrations by their Execution Times (aka Start Times).This means that when invoking the Rollback command:
executionversion order, the last executed migration will be rollbacked.executionversion order and a-d (date)option, the migration start times will be used to determine the target version to rollback to. In other words, all migrations which were executed after that date will be rollbacked.executionversion order and a-t (target version)option, all migrations which were executed after the target version was executed will be rollbacked.In terms of testing:
testRollbacksByDatetest was renamed totestRollbackToDateTimeand turned into a unit test, ensuring therollbackmethod is called with the right target version. A newtestRollbackwas added which ensures the correct output of the rollback operation (as was being done in the oldtestRollbacksByDatetest).RollbackTestandStatusTest.Other notes:
rollbackandrollbackToDateTimemethods were merged into a singlerollbackmethod that handles all cases and version orders.